Re: [PATCH] IPv6 support for NFS server

2008-01-18 Thread J. Bruce Fields
On Fri, Jan 18, 2008 at 03:50:56PM +0100, Aurélien Charbon wrote: OK Bruce I have added this comment before the patch. I have also done the changes pointed by Brian. Please let me know if there is still something to change. Thanks. For the future, if you could just make the comment part of

Re: [PATCH] IPv6 support for NFS server

2008-01-18 Thread Aurélien Charbon
OK Bruce I have added this comment before the patch. I have also done the changes pointed by Brian. Please let me know if there is still something to change. Regards, Aurélien J. Bruce Fields wrote: On Thu, Jan 17, 2008 at 06:04:35PM +0100, Aurélien Charbon wrote: Hi Bruce. Thanks for

Re: [PATCH] IPv6 support for NFS server

2008-01-17 Thread Aurélien Charbon
Hi Bruce. Thanks for your comments. Here is the patch with some cleanups. Regards, Aurélien -- Aurelien Charbon Linux NFSv4 team Bull SAS Echirolles - France http://nfsv4.bullopensource.org/ From

Re: [PATCH] IPv6 support for NFS server

2008-01-17 Thread Brian Haley
Aurélien Charbon wrote: Thanks for your comments. Here is the patch with some cleanups. Hi Aurelien, Just two nits. --- a/include/net/ipv6.h +++ b/include/net/ipv6.h @@ -400,6 +400,15 @@ static inline int ipv6_addr_v4mapped(const struct in6_addr *a) a-s6_addr32[2] ==

Re: [PATCH] IPv6 support for NFS server

2008-01-17 Thread J. Bruce Fields
On Thu, Jan 17, 2008 at 06:04:35PM +0100, Aurélien Charbon wrote: Hi Bruce. Thanks for your comments. Here is the patch with some cleanups. Thanks for the revisions. We need to submit this with a patch comment that: - Explains more precisely what this does (fixes export

Re: [PATCH] IPv6 support for NFS server

2008-01-15 Thread J. Bruce Fields
c19360e877cfa1576dce98792cd513665deaa2ec Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Aur=C3=A9lien=20Charbon?= [EMAIL PROTECTED] Date: Fri, 21 Dec 2007 16:44:46 +0100 Subject: [PATCH] IPv6 support for NFS server Prepare for IPv6 text-based mounts and exports. Tested with IPv4 network and basic nfs ops (mount, file

Re: [PATCH] IPv6 support for NFS server

2008-01-15 Thread J. Bruce Fields
Mostly just more trivial stuff for now, apologies: On Tue, Jan 15, 2008 at 05:32:21PM -0500, J. Bruce Fields wrote: diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c index cbbc594..e29b431 100644 --- a/fs/nfsd/export.c +++ b/fs/nfsd/export.c @@ -35,6 +35,7 @@ #include linux/lockd/bind.h

Re: [PATCH] IPv6 support for NFS server

2007-12-11 Thread Aurélien Charbon
J. Bruce Fields wrote: On Mon, Dec 10, 2007 at 07:34:41PM +0100, Aurélien Charbon wrote: Here is a cleanup for the ip_map caching patch in nfs server. It prepares for IPv6 text-based mounts and exports. Tests: tested with only IPv4 network and basic nfs ops (mount, file creation and

Re: [PATCH] IPv6 support for NFS server

2007-12-11 Thread Brian Haley
Hi Aurelien, Aurélien Charbon wrote: Here is a cleanup for the ip_map caching patch in nfs server. It prepares for IPv6 text-based mounts and exports. Tests: tested with only IPv4 network and basic nfs ops (mount, file creation and modification) In an email back on October 29th I sent-out

Re: [PATCH] IPv6 support for NFS server

2007-12-11 Thread Aurélien Charbon
Brian Haley wrote: In an email back on October 29th I sent-out a similar patch with a new ipv6_addr_set_v4mapped() inline - it might be useful to pull that piece into your patch since it cleans it up a bit to get rid of the ipv6_addr_set() calls. I can re-send you that patch off-line if you

Re: [PATCH] IPv6 support for NFS server

2007-12-11 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Tue, 11 Dec 2007 19:00:08 +0100), Aurélien Charbon [EMAIL PROTECTED] says: --- linux-2.6.24-rc4/include/net/ipv6.h 2007-12-10 16:11:38.0 +0100 +++ linux-2.6.24-rc4-IPv6-cache-based/include/net/ipv6.h 2007-12-11 17:52:39.0 +0100

[PATCH] IPv6 support for NFS server

2007-12-10 Thread Aurélien Charbon
Here is a cleanup for the ip_map caching patch in nfs server. It prepares for IPv6 text-based mounts and exports. Tests: tested with only IPv4 network and basic nfs ops (mount, file creation and modification) - Signed-off-by: Aurelien Charbon [EMAIL PROTECTED] diff -p -u -r -N

Re: [PATCH] IPv6 support for NFS server

2007-12-10 Thread J. Bruce Fields
On Mon, Dec 10, 2007 at 07:34:41PM +0100, Aurélien Charbon wrote: Here is a cleanup for the ip_map caching patch in nfs server. It prepares for IPv6 text-based mounts and exports. Tests: tested with only IPv4 network and basic nfs ops (mount, file creation and modification) Thanks! And