Re: [PATCH] NFC: fix device-allocation error return

2017-11-05 Thread Samuel Ortiz
Hi Johan, On Sun, Jul 09, 2017 at 01:08:58PM +0200, Johan Hovold wrote: > A recent change fixing NFC device allocation itself introduced an > error-handling bug by returning an error pointer in case device-id > allocation failed. This is clearly broken as the callers still expected > NULL to be

Re: [PATCH] NFC: fix device-allocation error return

2017-08-28 Thread Johan Hovold
Samuel or David, On Sat, Jul 22, 2017 at 03:32:28PM +0200, Johan Hovold wrote: > On Sun, Jul 09, 2017 at 01:08:58PM +0200, Johan Hovold wrote: > > A recent change fixing NFC device allocation itself introduced an > > error-handling bug by returning an error pointer in case device-id > >

Re: [PATCH] NFC: fix device-allocation error return

2017-07-22 Thread Johan Hovold
On Sun, Jul 09, 2017 at 01:08:58PM +0200, Johan Hovold wrote: > A recent change fixing NFC device allocation itself introduced an > error-handling bug by returning an error pointer in case device-id > allocation failed. This is clearly broken as the callers still expected > NULL to be returned on

[PATCH] NFC: fix device-allocation error return

2017-07-09 Thread Johan Hovold
A recent change fixing NFC device allocation itself introduced an error-handling bug by returning an error pointer in case device-id allocation failed. This is clearly broken as the callers still expected NULL to be returned on errors as detected by Dan's static checker. Fix this up by returning