Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"

2016-10-26 Thread David Miller
From: Sven Eckelmann Date: Sat, 22 Oct 2016 09:46:24 +0200 > The maximum MTU is defined via the slave devices of an batman-adv > interface. Thus it is not possible to calculate the max_mtu during the > creation of the batman-adv device when no slave devices are attached.

Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"

2016-10-23 Thread Jarod Wilson
On Sun, Oct 23, 2016 at 09:17:50AM +0200, Sven Eckelmann wrote: > On Samstag, 22. Oktober 2016 21:08:26 CEST Jarod Wilson wrote: > [...] > > You're going to > > need more than just this revert though, since batman-adv calls > > ether_setup, which will set min_mtu = 68, max_mtu = 1500, unless > >

Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"

2016-10-23 Thread Sven Eckelmann
On Samstag, 22. Oktober 2016 21:08:26 CEST Jarod Wilson wrote: [...] > You're going to > need more than just this revert though, since batman-adv calls > ether_setup, which will set min_mtu = 68, max_mtu = 1500, unless > batadv_hardif_min_mtu() always returns something 1500 or less. It does only

Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"

2016-10-22 Thread Jarod Wilson
On Sat, Oct 22, 2016 at 09:46:24AM +0200, Sven Eckelmann wrote: > The maximum MTU is defined via the slave devices of an batman-adv > interface. Thus it is not possible to calculate the max_mtu during the > creation of the batman-adv device when no slave devices are attached. Doing > so would for

[PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"

2016-10-22 Thread Sven Eckelmann
The maximum MTU is defined via the slave devices of an batman-adv interface. Thus it is not possible to calculate the max_mtu during the creation of the batman-adv device when no slave devices are attached. Doing so would for example break non-fragmentation setups which then (incorrectly) allow an