Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-20 Thread Dave Hansen
On Mon, 2008-02-18 at 11:00 +0100, Jan-Bernd Themann wrote: Dave Hansen [EMAIL PROTECTED] wrote on 15.02.2008 17:55:38: I've been thinking about that, and I don't think you really *need* to keep a comprehensive map like that. When the memory is in a particular configuration (range of

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-18 Thread Jan-Bernd Themann
switching to proper mail client... Dave Hansen [EMAIL PROTECTED] wrote on 15.02.2008 17:55:38: I've been thinking about that, and I don't think you really *need* to keep a comprehensive map like that. When the memory is in a particular configuration (range of memory present along with

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-15 Thread Christoph Raisch
Dave Hansen [EMAIL PROTECTED] wrote on 14.02.2008 18:12:43: On Thu, 2008-02-14 at 09:46 +0100, Christoph Raisch wrote: Dave Hansen [EMAIL PROTECTED] wrote on 13.02.2008 18:05:00: On Wed, 2008-02-13 at 16:17 +0100, Jan-Bernd Themann wrote: Constraints imposed by HW / FW: - eHEA has

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-15 Thread Dave Hansen
On Fri, 2008-02-15 at 14:22 +0100, Christoph Raisch wrote: A translation from kernel to ehea_bmap space should be fast and predictable (ruling out hashes). If a driver doesn't know anything else about the mapping structure, the normal solution in kernel for this type of problem is a multi

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-14 Thread Christoph Raisch
Dave Hansen [EMAIL PROTECTED] wrote on 13.02.2008 18:05:00: On Wed, 2008-02-13 at 16:17 +0100, Jan-Bernd Themann wrote: Constraints imposed by HW / FW: - eHEA has own MMU - eHEA Memory Regions (MRs) are used by the eHEA MMU to translate virtual addresses to absolute addresses (like

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-14 Thread Dave Hansen
On Thu, 2008-02-14 at 09:46 +0100, Christoph Raisch wrote: Dave Hansen [EMAIL PROTECTED] wrote on 13.02.2008 18:05:00: On Wed, 2008-02-13 at 16:17 +0100, Jan-Bernd Themann wrote: Constraints imposed by HW / FW: - eHEA has own MMU - eHEA Memory Regions (MRs) are used by the eHEA MMU

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-14 Thread Badari Pulavarty
On Thu, 2008-02-14 at 09:12 -0800, Dave Hansen wrote: .. - Use currently other not exported functions in kernel/resource.c, like walk_memory_resource (where we would still need the maximum possible number of pages NR_MEM_SECTIONS) It isn't the act of exporting that's the

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-14 Thread Dave Hansen
On Thu, 2008-02-14 at 09:36 -0800, Badari Pulavarty wrote: I am not sure what you are trying to do with walk_memory_resource(). The behavior is different on ppc64. Hotplug memory usage assumes that all the memory resources (all system memory, not just IOMEM) are represented in

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-13 Thread Jan-Bernd Themann
Hi Dave, On Monday 11 February 2008 17:47, Dave Hansen wrote: Also, just ripping down and completely re-doing the entire mass of cards every time a 16MB area of memory is added or removed seems like an awfully big sledgehammer to me. I would *HATE* to see anybody else using this driver as an

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-13 Thread Dave Hansen
On Wed, 2008-02-13 at 16:17 +0100, Jan-Bernd Themann wrote: Constraints imposed by HW / FW: - eHEA has own MMU - eHEA Memory Regions (MRs) are used by the eHEA MMU to translate virtual addresses to absolute addresses (like DMA mapped memory on a PCI bus) - The number of MRs is limited

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-12 Thread Dave Hansen
On Mon, 2008-02-11 at 17:24 +0100, Jan-Bernd Themann wrote: Drivers like eHEA need memory notifiers in order to update their internal DMA memory map when memory is added to or removed from the system. Patch for eHEA memory hotplug support that uses these functions:

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-11 Thread Dave Hansen
On Mon, 2008-02-11 at 17:24 +0100, Jan-Bernd Themann wrote: Drivers like eHEA need memory notifiers in order to update their internal DMA memory map when memory is added to or removed from the system. Patch for eHEA memory hotplug support that uses these functions:

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-11 Thread Dave Hansen
On Mon, 2008-02-11 at 16:57 +0100, Jan-Bernd Themann wrote: Drivers like eHEA need memory notifiers in order to update their internal DMA memory map when memory is added to or removed from the system. Could you post this with the new users as well so we can make sure they're not abusing this

[PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-11 Thread Jan-Bernd Themann
Drivers like eHEA need memory notifiers in order to update their internal DMA memory map when memory is added to or removed from the system. Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- Hi, this is the modified version with EXPORT_SYMBOL_GPL Regards, Jan-Bernd

[PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-11 Thread Jan-Bernd Themann
Drivers like eHEA need memory notifiers in order to update their internal DMA memory map when memory is added to or removed from the system. Patch for eHEA memory hotplug support that uses these functions: http://www.spinics.net/lists/netdev/msg54484.html Signed-off-by: Jan-Bernd Themann [EMAIL

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-11 Thread Sam Ravnborg
On Mon, Feb 11, 2008 at 04:57:06PM +0100, Jan-Bernd Themann wrote: Drivers like eHEA need memory notifiers in order to update their internal DMA memory map when memory is added to or removed from the system. Can you please add proper kernel-doc formatted comments when you export a symbol so

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-11 Thread Dave Hansen
On Mon, 2008-02-11 at 17:24 +0100, Jan-Bernd Themann wrote: the eHEA patch belongs to a patchset that is usually added by Jeff Garzik once this dependency (EXPORTS) is resolved. I know that's already in mainline but, man, that code is nasty. It has stuff indented 7 levels or so and is