On Tue, May 22, 2007 at 10:02:53AM -0700, Kok, Auke wrote:
I've posted that before and it's up to the stable team. I think that it's a
seriously toolarge change unless Herbert posts his short version of the fix
for 2.6.21.1. I would be OK with that.
This patch should work for 2.6.21.
* Herbert Xu ([EMAIL PROTECTED]) wrote:
On Tue, May 22, 2007 at 10:02:53AM -0700, Kok, Auke wrote:
I've posted that before and it's up to the stable team. I think that it's a
seriously toolarge change unless Herbert posts his short version of the fix
for 2.6.21.1. I would be OK with
Chris Wright wrote:
* Herbert Xu ([EMAIL PROTECTED]) wrote:
On Tue, May 22, 2007 at 10:02:53AM -0700, Kok, Auke wrote:
I've posted that before and it's up to the stable team. I think that it's a
seriously toolarge change unless Herbert posts his short version of the fix
for 2.6.21.1. I would
On Wed, May 23, 2007 at 04:34:18PM -0700, Chris Wright wrote:
Mind adding an updated changelog and signed-off-by please?
Sure.
[E1000]: Fix netif_poll_enable crash in e1000_open
e1000_open calls e1000_up which will always call netif_poll_enable.
However, it's illegal to call
On Wed, May 23, 2007 at 04:38:20PM -0700, Kok, Auke wrote:
With that, please add my Acked-By...
Sorry, I only read yours after Chris's message :)
Chris, please add that Acked-By by Auke.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home
* Herbert Xu ([EMAIL PROTECTED]) wrote:
On Wed, May 23, 2007 at 04:38:20PM -0700, Kok, Auke wrote:
With that, please add my Acked-By...
Sorry, I only read yours after Chris's message :)
Chris, please add that Acked-By by Auke.
Got it, thanks.
-chris
-
To unsubscribe from this list:
Herbert Xu wrote:
On Mon, May 21, 2007 at 07:42:39PM -0400, Jeff Garzik wrote:
applied, though as a poster (DaveJ?) noted, I'm not sure it completely
fixes the bug
It should fix the problem completely in 2.6.22. For 2.6.21, we need
a different fix because e1000_open is directly calling
Chuck Ebbert wrote:
Herbert Xu wrote:
On Mon, May 21, 2007 at 07:42:39PM -0400, Jeff Garzik wrote:
applied, though as a poster (DaveJ?) noted, I'm not sure it completely
fixes the bug
It should fix the problem completely in 2.6.22. For 2.6.21, we need
a different fix because e1000_open is
Herbert Xy wrote:
netif_poll_enable can only be called if you've previously called
netif_poll_disable. Otherwise a poll might already be in action
and you may get a crash like this.
Removing the call to netif_poll_enable in e1000_open should fix this issue,
the only other call to
On Mon, May 21, 2007 at 08:32:41AM -0700, Auke Kok wrote:
Herbert Xy wrote:
netif_poll_enable can only be called if you've previously called
netif_poll_disable. Otherwise a poll might already be in action
and you may get a crash like this.
Removing the call to netif_poll_enable in
Herbert Xu wrote:
netif_poll_enable can only be called if you've previously called
netif_poll_disable. Otherwise a poll might already be in action
and you may get a crash like this.
Removing the call to netif_poll_enable in e1000_open should fix this issue,
the only other call to
On Mon, May 21, 2007 at 02:51:35PM -0700, Auke Kok wrote:
Herbert Xu wrote:
netif_poll_enable can only be called if you've previously called
netif_poll_disable. Otherwise a poll might already be in action
and you may get a crash like this.
Removing the call to netif_poll_enable in
Auke Kok wrote:
Herbert Xu wrote:
netif_poll_enable can only be called if you've previously called
netif_poll_disable. Otherwise a poll might already be in action
and you may get a crash like this.
Removing the call to netif_poll_enable in e1000_open should fix this issue,
the only other call
Jeff Garzik wrote:
Auke Kok wrote:
Herbert Xu wrote:
netif_poll_enable can only be called if you've previously called
netif_poll_disable. Otherwise a poll might already be in action
and you may get a crash like this.
Removing the call to netif_poll_enable in e1000_open should fix this issue,
On Mon, May 21, 2007 at 06:16:35PM -0400, Dave Jones wrote:
On Mon, May 21, 2007 at 02:51:35PM -0700, Auke Kok wrote:
Herbert Xu wrote:
netif_poll_enable can only be called if you've previously called
netif_poll_disable. Otherwise a poll might already be in action
and you may get a
Herbert Xu wrote:
On Mon, May 21, 2007 at 06:16:35PM -0400, Dave Jones wrote:
On Mon, May 21, 2007 at 02:51:35PM -0700, Auke Kok wrote:
Herbert Xu wrote:
netif_poll_enable can only be called if you've previously called
netif_poll_disable. Otherwise a poll might already be in action
and
On Mon, May 21, 2007 at 07:42:39PM -0400, Jeff Garzik wrote:
applied, though as a poster (DaveJ?) noted, I'm not sure it completely
fixes the bug
It should fix the problem completely in 2.6.22. For 2.6.21, we need
a different fix because e1000_open is directly calling e1000_up.
Cheers,
--
On Mon, May 21, 2007 at 05:58:27PM -0700, Kok, Auke wrote:
This probably doesn't solve the latter bug.
The code you reference isn't there in the kernel tested in that bug
(2.6.21) In 2.6.21, netif_poll_enable is only called from
e1000_up(), not e1000_open()
Yes we need a
18 matches
Mail list logo
