Re: [PATCH] flow disector: check if arp_eth is null rather than arp

On Fri, 2017-01-13 at 18:25 +, Colin Ian King wrote: > On 13/01/17 18:24, Eric Dumazet wrote: > > It looks that we try very hard to add critical bugs in flow dissector. > > > > This is embarrassing really. > > > > I am questioning if the __skb_header_pointer() is correct > > > > Why using

Re: [PATCH] flow disector: check if arp_eth is null rather than arp

On Fri, 2017-01-13 at 13:34 +, Colin King wrote: > From: Colin Ian King > > arp is being checked instead of arp_eth to see if the call to > __skb_header_pointer failed. Fix this by checking arp_eth is > null instead of arp. > > CoverityScan CID#1396428 ("Logically

Re: [PATCH] flow disector: check if arp_eth is null rather than arp

On 13/01/17 18:24, Eric Dumazet wrote: > On Fri, 2017-01-13 at 13:34 +, Colin King wrote: >> From: Colin Ian King >> >> arp is being checked instead of arp_eth to see if the call to >> __skb_header_pointer failed. Fix this by checking arp_eth is >> null instead of

[PATCH] flow disector: check if arp_eth is null rather than arp

From: Colin Ian King arp is being checked instead of arp_eth to see if the call to __skb_header_pointer failed. Fix this by checking arp_eth is null instead of arp. CoverityScan CID#1396428 ("Logically dead code") on 2nd arp comparison (which should be arp_eth