Re: [PATCH] flowi: add concept of "not_oif"

2016-02-05 Thread Jason A. Donenfeld
On Thu, Feb 4, 2016 at 4:44 AM, Eric Dumazet wrote: > On Wed, 2016-02-03 at 22:02 +0100, Jason A. Donenfeld wrote: > >> >> > I don't know about the particular problems with >> > tunnels but the scripts can use the route metric to order >> > the routes in a table.

Re: [PATCH] flowi: add concept of "not_oif"

2016-02-03 Thread Julian Anastasov
Hello, On Wed, 3 Feb 2016, Jason A. Donenfeld wrote: > This patch simply adds support for specifying a "not_oif" device in > flowi4 and flowi6 lookups, that will find a matching route that _isn't_ > via the specified device. If you check every flowi4_oif user you will notice

Re: [PATCH] flowi: add concept of "not_oif"

2016-02-03 Thread Jason A. Donenfeld
Hi Julian, Thanks a lot for your review. Much appreciated. On Wed, Feb 3, 2016 at 9:42 PM, Julian Anastasov wrote: > If you check every flowi4_oif user you will notice > that some places can not fulfil this requirement: > - fib_select_path -> fib_select_multipath >

Re: [PATCH] flowi: add concept of "not_oif"

2016-02-03 Thread Eric Dumazet
On Wed, 2016-02-03 at 22:02 +0100, Jason A. Donenfeld wrote: > > > I don't know about the particular problems with > > tunnels but the scripts can use the route metric to order > > the routes in a table. > > This unfortunately does not cut it with tunnels. ip rule show ip route show

[PATCH] flowi: add concept of "not_oif"

2016-02-03 Thread Jason A. Donenfeld
This patch simply adds support for specifying a "not_oif" device in flowi4 and flowi6 lookups, that will find a matching route that _isn't_ via the specified device. Signed-off-by: Jason A. Donenfeld --- include/net/flow.h | 3 +++ net/ipv4/fib_trie.c | 2 ++ net/ipv6/route.c