Re: Re: [Intel-wired-lan] [PATCH] ixgbe: initialize u64_stats_sync structures early at ixgbe_probe

On Tue, Apr 25, 2017 at 8:39 AM, Lino Sanfilippo wrote: > Hi, > >> This patch doesn't look right to me. I would suggest rejecting it. >> >> The call to initialize the stats should be done when the ring is >> allocated, not in ixgbe_probe(). This should probably be done in

Aw: Re: [Intel-wired-lan] [PATCH] ixgbe: initialize u64_stats_sync structures early at ixgbe_probe

Hi, > This patch doesn't look right to me. I would suggest rejecting it. > > The call to initialize the stats should be done when the ring is > allocated, not in ixgbe_probe(). This should probably be done in > ixgbe_alloc_q_vector() instead. > AFAICS ixgbe_alloc_q_vector() is also called in

Re: [Intel-wired-lan] [PATCH] ixgbe: initialize u64_stats_sync structures early at ixgbe_probe

PM > To: Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com> > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; > linux-ker...@vger.kernel.org; Song, Liwei (Wind River) > <liwei.s...@windriver.com> > Subject: [Intel-wired-lan] [PATCH] ixgbe: initialize u64

RE: [Intel-wired-lan] [PATCH] ixgbe: initialize u64_stats_sync structures early at ixgbe_probe

ux-ker...@vger.kernel.org; Song, Liwei (Wind River) <liwei.s...@windriver.com> Subject: [Intel-wired-lan] [PATCH] ixgbe: initialize u64_stats_sync structures early at ixgbe_probe Fix the following CallTrace: INFO: trying to register non-static key. the code is fine but needs lockdep annotation.

[PATCH] ixgbe: initialize u64_stats_sync structures early at ixgbe_probe

Fix the following CallTrace: INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 71 PID: 1 Comm: swapper/0 Not tainted 4.8.8-WR9.0.0.1_standard #11 Hardware name: Intel Corporation S2600WTT/S2600WTT, BIOS