David Miller wrote:
From: Jeff Garzik [EMAIL PROTECTED]
Date: Sat, 19 May 2007 21:47:00 -0400
According to the implementation, netif_rx() can fail.
It doesn't exactly fail, but it does give return values
which indicate RX congestion.
Assuming you're referring to NET_RX_CN_*, this
Stephen Hemminger wrote:
The skb is always consumed so the the return value is informational only.
Yes, this is true. Handing off an skb to netif_rx() relieves the driver
of further responsibility for it.
Jeff
-
To unsubscribe from this list: send the line unsubscribe netdev in
From: Jeff Garzik [EMAIL PROTECTED]
Date: Sat, 19 May 2007 21:47:00 -0400
Dan Williams wrote:
On Fri, 2007-05-18 at 14:09 -0400, John W. Linville wrote:
On Wed, May 16, 2007 at 05:01:27PM -0400, Florin Malita wrote:
In libertas_process_rxed_packet() and process_rxed_802_11_packet() the
On Fri, 2007-05-18 at 14:09 -0400, John W. Linville wrote:
On Wed, May 16, 2007 at 05:01:27PM -0400, Florin Malita wrote:
In libertas_process_rxed_packet() and process_rxed_802_11_packet() the
skb is dereferenced after being passed to netif_rx (called from
libertas_upload_rx_packet).
Dan Williams wrote:
On Fri, 2007-05-18 at 14:09 -0400, John W. Linville wrote:
On Wed, May 16, 2007 at 05:01:27PM -0400, Florin Malita wrote:
In libertas_process_rxed_packet() and process_rxed_802_11_packet() the
skb is dereferenced after being passed to netif_rx (called from
On Sat, 19 May 2007 21:47:00 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
Dan Williams wrote:
On Fri, 2007-05-18 at 14:09 -0400, John W. Linville wrote:
On Wed, May 16, 2007 at 05:01:27PM -0400, Florin Malita wrote:
In libertas_process_rxed_packet() and process_rxed_802_11_packet() the
On Wed, May 16, 2007 at 05:01:27PM -0400, Florin Malita wrote:
In libertas_process_rxed_packet() and process_rxed_802_11_packet() the
skb is dereferenced after being passed to netif_rx (called from
libertas_upload_rx_packet). Spotted by Coverity (1658, 1659).
Relocating the
John W. Linville wrote:
Also, libertas_upload_rx_packet() unconditionally returns 0 so the error
check is dead code - might as well take it out.
Is this merely an implementation detail? Or an absolute fact?
I believe it's an absolute fact that got lost among implementation
details
On Fri, 18 May 2007 14:09:03 -0400
John W. Linville [EMAIL PROTECTED] wrote:
On Wed, May 16, 2007 at 05:01:27PM -0400, Florin Malita wrote:
In libertas_process_rxed_packet() and process_rxed_802_11_packet() the
skb is dereferenced after being passed to netif_rx (called from
Stephen Hemminger wrote:
netif_rx() used to return a value in older kernels.
netif_rx() returns a value in current kernels.
Jeff
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
In libertas_process_rxed_packet() and process_rxed_802_11_packet() the
skb is dereferenced after being passed to netif_rx (called from
libertas_upload_rx_packet). Spotted by Coverity (1658, 1659).
Also, libertas_upload_rx_packet() unconditionally returns 0 so the error
check is dead code -
11 matches
Mail list logo