Re: [PATCH] make net_gso_ok return false when gso_type is zero(invalid)

2018-04-11 Thread Wenhua Shi
> Note that TCP stack now works with GSO being always on. > 0a6b2a1dc2a2 ("tcp: switch to GSO being always on") I've tested on the latest net-next branch 17dec0a949153d9ac00760ba2f5b78cb583e995f. The problem still exists. My patch won't work. Reverting commit 0a6b2a1dc2a2 won't help.

Re: [PATCH] make net_gso_ok return false when gso_type is zero(invalid)

2018-04-10 Thread Wenhua Shi
2018-04-10 18:32 GMT+02:00 Marcelo Ricardo Leitner : > On Sun, Apr 08, 2018 at 08:41:21PM +0200, Wenhua Shi wrote: >> 2018-04-08 18:51 GMT+02:00 David Miller : >> > >> > From: Wenhua Shi >> > Date: Fri, 6 Apr 2018 03:43:39 +0200 >> > >> > > Signed-off-by: Wenhua Shi >> > >> > This precondition s

Re: [PATCH] make net_gso_ok return false when gso_type is zero(invalid)

2018-04-10 Thread Marcelo Ricardo Leitner
On Sun, Apr 08, 2018 at 08:41:21PM +0200, Wenhua Shi wrote: > 2018-04-08 18:51 GMT+02:00 David Miller : > > > > From: Wenhua Shi > > Date: Fri, 6 Apr 2018 03:43:39 +0200 > > > > > Signed-off-by: Wenhua Shi > > > > This precondition should be made impossible instead of having to do > > an extra c

Re: [PATCH] make net_gso_ok return false when gso_type is zero(invalid)

2018-04-08 Thread Wenhua Shi
2018-04-08 18:51 GMT+02:00 David Miller : > > From: Wenhua Shi > Date: Fri, 6 Apr 2018 03:43:39 +0200 > > > Signed-off-by: Wenhua Shi > > This precondition should be made impossible instead of having to do > an extra check everywhere that this helper is invoked, many of which > are in fast paths

Re: [PATCH] make net_gso_ok return false when gso_type is zero(invalid)

2018-04-08 Thread David Miller
From: Wenhua Shi Date: Fri, 6 Apr 2018 03:43:39 +0200 > Signed-off-by: Wenhua Shi This precondition should be made impossible instead of having to do an extra check everywhere that this helper is invoked, many of which are in fast paths.

[PATCH] make net_gso_ok return false when gso_type is zero(invalid)

2018-04-05 Thread Wenhua Shi
Signed-off-by: Wenhua Shi --- include/linux/netdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index cf44503e..1f26cbcf 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -4187,7 +4187,7 @@ s