Re: [PATCH] net: chelsio: cxgb3: constify attribute_group structures.

2017-07-10 Thread Arvind Yadav
Hi Joe, On Tuesday 11 July 2017 11:17 AM, Joe Perches wrote: On Tue, 2017-07-11 at 11:11 +0530, Arvind Yadav wrote: Hi Joe, On Monday 10 July 2017 10:30 PM, Joe Perches wrote: On Mon, 2017-07-10 at 16:04 +0530, Arvind Yadav wrote: attribute_groups are not supposed to change at runtime.

Re: [PATCH] net: chelsio: cxgb3: constify attribute_group structures.

2017-07-10 Thread Joe Perches
On Tue, 2017-07-11 at 11:11 +0530, Arvind Yadav wrote: > Hi Joe, > > > On Monday 10 July 2017 10:30 PM, Joe Perches wrote: > > On Mon, 2017-07-10 at 16:04 +0530, Arvind Yadav wrote: > > > attribute_groups are not supposed to change at runtime. All functions > > > working with attribute_groups

Re: [PATCH] net: chelsio: cxgb3: constify attribute_group structures.

2017-07-10 Thread Arvind Yadav
Hi Joe, On Monday 10 July 2017 10:30 PM, Joe Perches wrote: On Mon, 2017-07-10 at 16:04 +0530, Arvind Yadav wrote: attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as

Re: [PATCH] net: chelsio: cxgb3: constify attribute_group structures.

2017-07-10 Thread Joe Perches
On Mon, 2017-07-10 at 16:04 +0530, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work > with const attribute_group. So mark the non-const structs as const. I think it's good you are doing all of these.

[PATCH] net: chelsio: cxgb3: constify attribute_group structures.

2017-07-10 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: textdata bss dec hex filename 28720 985 12 297177415