Re: [PATCH] net: ethernet: aquantia: default to no in config

2017-09-20 Thread Sergei Shtylyov
Hello! On 9/20/2017 1:43 AM, Vito Caputo wrote: NET_VENDOR_AQUANTIA was "default y" for some reason, which seems obviously inappropriate. --- drivers/net/ethernet/aquantia/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aquantia/Kconfig

Re: [PATCH] net: ethernet: aquantia: default to no in config

2017-09-19 Thread David Miller
From: vcap...@pengaru.com Date: Tue, 19 Sep 2017 16:02:49 -0700 > Out of curiosity, what's the rationale for that decision? So that you don't need to know what special vendor knob needs to be switched in order to even be offered the config knob for the driver you are interested in.

Re: [PATCH] net: ethernet: aquantia: default to no in config

2017-09-19 Thread vcaputo
On Tue, Sep 19, 2017 at 03:52:31PM -0700, David Miller wrote: > From: Vito Caputo > Date: Tue, 19 Sep 2017 15:43:15 -0700 > > > NET_VENDOR_AQUANTIA was "default y" for some reason, which seems > > obviously inappropriate. > > It is appropriate. > > We make all vendor

Re: [PATCH] net: ethernet: aquantia: default to no in config

2017-09-19 Thread David Miller
From: Vito Caputo Date: Tue, 19 Sep 2017 15:43:15 -0700 > NET_VENDOR_AQUANTIA was "default y" for some reason, which seems > obviously inappropriate. It is appropriate. We make all vendor guards default to yes.

[PATCH] net: ethernet: aquantia: default to no in config

2017-09-19 Thread Vito Caputo
NET_VENDOR_AQUANTIA was "default y" for some reason, which seems obviously inappropriate. --- drivers/net/ethernet/aquantia/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aquantia/Kconfig b/drivers/net/ethernet/aquantia/Kconfig index