Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx

[Lino Sanfilippo]

On 30.10.2017 19:04, Jakub Kicinski wrote:
> On Sun, 29 Oct 2017 13:38:09 +, Colin King wrote:
>> From: Colin Ian King 
>>
>> Variable idx is being initialized and later on over-written by
>> a new value in a do-loop without the initial value ever being
>> read. Hence the initializion is redundant and can be removed.
>> Cleans up clang warning:
>>
>> drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value
>> stored to 'idx' during its initialization is never read
>>
>> Signed-off-by: Colin Ian King 
>> ---
>>  drivers/net/ethernet/alacritech/slicoss.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/alacritech/slicoss.c 
>> b/drivers/net/ethernet/alacritech/slicoss.c
>> index 15a8096c60df..ac8004186fa8 100644
>> --- a/drivers/net/ethernet/alacritech/slicoss.c
>> +++ b/drivers/net/ethernet/alacritech/slicoss.c
>> @@ -355,7 +355,7 @@ static void slic_xmit_complete(struct slic_device *sdev)
>>  {
>>  struct slic_tx_queue *txq = >txq;
>>  struct net_device *dev = sdev->netdev;
>> -unsigned int idx = txq->done_idx;
>> +unsigned int idx;
>>  struct slic_tx_buffer *buff;
>>  unsigned int frames = 0;
>>  unsigned int bytes = 0;
> 
> You should probably reorder the variables now so they stay longest to
> shortest.
> 

I agree. While the change itself is ok, it would be nice if
we could keep the order of the variables by length. 

Regards,
Lino

Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx

[Jakub Kicinski]

On Sun, 29 Oct 2017 13:38:09 +, Colin King wrote:
> From: Colin Ian King 
> 
> Variable idx is being initialized and later on over-written by
> a new value in a do-loop without the initial value ever being
> read. Hence the initializion is redundant and can be removed.
> Cleans up clang warning:
> 
> drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value
> stored to 'idx' during its initialization is never read
> 
> Signed-off-by: Colin Ian King 
> ---
>  drivers/net/ethernet/alacritech/slicoss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/alacritech/slicoss.c 
> b/drivers/net/ethernet/alacritech/slicoss.c
> index 15a8096c60df..ac8004186fa8 100644
> --- a/drivers/net/ethernet/alacritech/slicoss.c
> +++ b/drivers/net/ethernet/alacritech/slicoss.c
> @@ -355,7 +355,7 @@ static void slic_xmit_complete(struct slic_device *sdev)
>  {
>   struct slic_tx_queue *txq = >txq;
>   struct net_device *dev = sdev->netdev;
> - unsigned int idx = txq->done_idx;
> + unsigned int idx;
>   struct slic_tx_buffer *buff;
>   unsigned int frames = 0;
>   unsigned int bytes = 0;

You should probably reorder the variables now so they stay longest to
shortest.

Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx

[Lino Sanfilippo]

Hi Colin,

On 29.10.2017 14:38, Colin King wrote:
> From: Colin Ian King 
> 
> Variable idx is being initialized and later on over-written by
> a new value in a do-loop without the initial value ever being
> read. Hence the initializion is redundant and can be removed.
> Cleans up clang warning:
> 
> drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value
> stored to 'idx' during its initialization is never read
> 
> Signed-off-by: Colin Ian King 
> ---
>  drivers/net/ethernet/alacritech/slicoss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/alacritech/slicoss.c 
> b/drivers/net/ethernet/alacritech/slicoss.c
> index 15a8096c60df..ac8004186fa8 100644
> --- a/drivers/net/ethernet/alacritech/slicoss.c
> +++ b/drivers/net/ethernet/alacritech/slicoss.c
> @@ -355,7 +355,7 @@ static void slic_xmit_complete(struct slic_device *sdev)
>  {
>   struct slic_tx_queue *txq = >txq;
>   struct net_device *dev = sdev->netdev;
> - unsigned int idx = txq->done_idx;
> + unsigned int idx;
>   struct slic_tx_buffer *buff;
>   unsigned int frames = 0;
>   unsigned int bytes = 0;
> 

Acked-by: Lino Sanfilippo 

Regards,
Lino

[PATCH] net: ethernet: slicoss: remove redundant initialization of idx

[Colin King]

From: Colin Ian King 

Variable idx is being initialized and later on over-written by
a new value in a do-loop without the initial value ever being
read. Hence the initializion is redundant and can be removed.
Cleans up clang warning:

drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value
stored to 'idx' during its initialization is never read

Signed-off-by: Colin Ian King 
---
 drivers/net/ethernet/alacritech/slicoss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/alacritech/slicoss.c 
b/drivers/net/ethernet/alacritech/slicoss.c
index 15a8096c60df..ac8004186fa8 100644
--- a/drivers/net/ethernet/alacritech/slicoss.c
+++ b/drivers/net/ethernet/alacritech/slicoss.c
@@ -355,7 +355,7 @@ static void slic_xmit_complete(struct slic_device *sdev)
 {
struct slic_tx_queue *txq = >txq;
struct net_device *dev = sdev->netdev;
-   unsigned int idx = txq->done_idx;
+   unsigned int idx;
struct slic_tx_buffer *buff;
unsigned int frames = 0;
unsigned int bytes = 0;
-- 
2.14.1