Re: [PATCH] net: ethernet: ti: cpsw: fix race condition during open()

2017-04-04 Thread David Miller
From: Sekhar Nori Date: Mon, 3 Apr 2017 17:34:28 +0530 > TI's cpsw driver handles both OF and non-OF case for phy > connect. Unfortunately of_phy_connect() returns NULL on > error while phy_connect() returns ERR_PTR(). > > To handle this, cpsw_slave_open() overrides the return

[PATCH] net: ethernet: ti: cpsw: fix race condition during open()

2017-04-03 Thread Sekhar Nori
TI's cpsw driver handles both OF and non-OF case for phy connect. Unfortunately of_phy_connect() returns NULL on error while phy_connect() returns ERR_PTR(). To handle this, cpsw_slave_open() overrides the return value from phy_connect() to make it NULL or error. This leaves a small window,