Re: [PATCH] net: ftgmac100: Fix oops in probe on failure to find associated PHY

2017-08-22 Thread David Miller
From: Andrew Jeffery Date: Tue, 22 Aug 2017 16:06:22 +0930 > netif_napi_del() should be paired with netif_napi_add(), however no > such call takes place in ftgmac100_probe(). This triggers a NULL > pointer dereference if e.g. no PHY is found by the MDIO probe: ... >

Re: [PATCH] net: ftgmac100: Fix oops in probe on failure to find associated PHY

2017-08-22 Thread Benjamin Herrenschmidt
On Tue, 2017-08-22 at 16:06 +0930, Andrew Jeffery wrote: > netif_napi_del() should be paired with netif_napi_add(), however no > such call takes place in ftgmac100_probe(). This triggers a NULL > pointer dereference if e.g. no PHY is found by the MDIO probe: > >[ 2.77] libphy: Fixed

[PATCH] net: ftgmac100: Fix oops in probe on failure to find associated PHY

2017-08-22 Thread Andrew Jeffery
netif_napi_del() should be paired with netif_napi_add(), however no such call takes place in ftgmac100_probe(). This triggers a NULL pointer dereference if e.g. no PHY is found by the MDIO probe: [ 2.77] libphy: Fixed MDIO Bus: probed [ 2.77] ftgmac100 1e66.ethernet: