Re: [PATCH] net: hip04: Remove superfluous ether_setup after alloc_etherdev

2016-10-17 Thread David Miller 
From: Tobias Klauser 
Date: Mon, 17 Oct 2016 09:22:04 +0200

> There is no need to call ether_setup after alloc_ethdev since it was
> already called there.
> 
> Signed-off-by: Tobias Klauser 

Applied to net-next, thanks.

[PATCH] net: hip04: Remove superfluous ether_setup after alloc_etherdev

2016-10-17 Thread Tobias Klauser 
There is no need to call ether_setup after alloc_ethdev since it was
already called there.

Signed-off-by: Tobias Klauser 
---
 drivers/net/ethernet/hisilicon/hip04_eth.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c 
b/drivers/net/ethernet/hisilicon/hip04_eth.c
index 3c99ca420f57..854befde0a08 100644
--- a/drivers/net/ethernet/hisilicon/hip04_eth.c
+++ b/drivers/net/ethernet/hisilicon/hip04_eth.c
@@ -897,7 +897,6 @@ static int hip04_mac_probe(struct platform_device *pdev)
 
INIT_WORK(>tx_timeout_task, hip04_tx_timeout_task);
 
-   ether_setup(ndev);
ndev->netdev_ops = _netdev_ops;
ndev->ethtool_ops = _ethtool_ops;
ndev->watchdog_timeo = TX_TIMEOUT;
-- 
2.9.0