Re: [PATCH] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings

2017-01-16 Thread Philippe Reynes
Hi Stephen, On 1/16/17, Stephen Hemminger wrote: > On Mon, 16 Jan 2017 12:36:17 -0500 (EST) > David Miller wrote: > >> From: Stephen Hemminger >> Date: Mon, 16 Jan 2017 09:29:51 -0800 >> >> > On Sat, 14 Jan 2017

Re: [PATCH] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings

2017-01-16 Thread Stephen Hemminger
On Mon, 16 Jan 2017 12:36:17 -0500 (EST) David Miller wrote: > From: Stephen Hemminger > Date: Mon, 16 Jan 2017 09:29:51 -0800 > > > On Sat, 14 Jan 2017 13:08:28 +0100 > > Philippe Reynes wrote: > > > >> The ethtool api

Re: [PATCH] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings

2017-01-16 Thread David Miller
From: Stephen Hemminger Date: Mon, 16 Jan 2017 09:29:51 -0800 > On Sat, 14 Jan 2017 13:08:28 +0100 > Philippe Reynes wrote: > >> The ethtool api {get|set}_settings is deprecated. >> We move this driver to new api {get|set}_link_ksettings. >> >>

Re: [PATCH] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings

2017-01-16 Thread Stephen Hemminger
On Sat, 14 Jan 2017 13:08:28 +0100 Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > The callback set_link_ksettings no longer update the value > of advertising, as the struct

[PATCH] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings

2017-01-14 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. The callback set_link_ksettings no longer update the value of advertising, as the struct ethtool_link_ksettings is defined as const. Signed-off-by: Philippe Reynes ---