Re: [PATCH] net: phy: at803x: the Atheros 8031 supports pause frames

2016-10-31 Thread Timur Tabi
Florian Fainelli wrote: pauseasym_pauseenable tx?enable rx? ------- 0 0 No No 0 1 YesNo 1 0 YesYes 1 1 No

Re: [PATCH] net: phy: at803x: the Atheros 8031 supports pause frames

2016-10-31 Thread Florian Fainelli
On 10/31/2016 10:23 AM, Timur Tabi wrote: > Florian Fainelli wrote: > >> May I suggest reading about standards a bit more, or just looking at >> other drivers, like tg3.c. > > I have been doing that for over six months now. There's only so much I > can glean from reading source code and

Re: [PATCH] net: phy: at803x: the Atheros 8031 supports pause frames

2016-10-31 Thread David Miller
From: Timur Tabi Date: Thu, 27 Oct 2016 17:05:01 -0500 > The Atheros 8031 PHY supports the 802.3 extension for symmetric and > asymmetric pause frames, so set that to the list of features supported > by the phy. > > Signed-off-by: Timur Tabi It

Re: [PATCH] net: phy: at803x: the Atheros 8031 supports pause frames

2016-10-31 Thread Timur Tabi
Florian Fainelli wrote: May I suggest reading about standards a bit more, or just looking at other drivers, like tg3.c. I have been doing that for over six months now. There's only so much I can glean from reading source code and standards documents. The inner workings of our NIC are a

Re: [PATCH] net: phy: at803x: the Atheros 8031 supports pause frames

2016-10-28 Thread Florian Fainelli
On 10/28/2016 01:06 PM, Timur Tabi wrote: > Florian Fainelli wrote: >> On 10/27/2016 03:24 PM, Timur Tabi wrote: >>> Florian Fainelli wrote: >>> Hu? In my experience that should not come from supporting Pause frames or not, but rather properly configuring a (RG)MII delay, but your

Re: [PATCH] net: phy: at803x: the Atheros 8031 supports pause frames

2016-10-28 Thread Timur Tabi
Florian Fainelli wrote: On 10/27/2016 03:24 PM, Timur Tabi wrote: Florian Fainelli wrote: Hu? In my experience that should not come from supporting Pause frames or not, but rather properly configuring a (RG)MII delay, but your mileage may vary. I can assure you, I'm more confused than you.

Re: [PATCH] net: phy: at803x: the Atheros 8031 supports pause frames

2016-10-27 Thread Florian Fainelli
On 10/27/2016 03:24 PM, Timur Tabi wrote: > Florian Fainelli wrote: > >> Hu? In my experience that should not come from supporting Pause frames >> or not, but rather properly configuring a (RG)MII delay, but your >> mileage may vary. > > I can assure you, I'm more confused than you. I've been

Re: [PATCH] net: phy: at803x: the Atheros 8031 supports pause frames

2016-10-27 Thread Timur Tabi
Florian Fainelli wrote: Hu? In my experience that should not come from supporting Pause frames or not, but rather properly configuring a (RG)MII delay, but your mileage may vary. I can assure you, I'm more confused than you. I've been working in this for almost two weeks, and not only does

Re: [PATCH] net: phy: at803x: the Atheros 8031 supports pause frames

2016-10-27 Thread Florian Fainelli
On 10/27/2016 03:05 PM, Timur Tabi wrote: > The Atheros 8031 PHY supports the 802.3 extension for symmetric and > asymmetric pause frames, so set that to the list of features supported > by the phy. > > Signed-off-by: Timur Tabi > --- > > Without this patch, my NIC (the

[PATCH] net: phy: at803x: the Atheros 8031 supports pause frames

2016-10-27 Thread Timur Tabi
The Atheros 8031 PHY supports the 802.3 extension for symmetric and asymmetric pause frames, so set that to the list of features supported by the phy. Signed-off-by: Timur Tabi --- Without this patch, my NIC (the Qualcomm EMAC) receives a lot of frame check sequence (aka