Re: [PATCH] net: rtnetlink: be more strict when setting MAC address

2015-08-17 Thread Phil Sutter
On Mon, Aug 17, 2015 at 02:09:33PM -0700, David Miller wrote: From: Phil Sutter p...@nwl.cc Date: Mon, 17 Aug 2015 23:06:47 +0200 Upon evaluation of IFLA_ADDRESS and IFLA_BROADCAST messages, make sure the passed argument length matches dev-addr_len exactly. This fixes dubious

[PATCH] net: rtnetlink: be more strict when setting MAC address

2015-08-17 Thread Phil Sutter
Upon evaluation of IFLA_ADDRESS and IFLA_BROADCAST messages, make sure the passed argument length matches dev-addr_len exactly. This fixes dubious behaviour of 'ip link set eth0 addr MAC' where 'MAC' is too long, e.g. '00:11:22:33:44:55:66:77'. Called like this, 'ip' would return successfully and

Re: [PATCH] net: rtnetlink: be more strict when setting MAC address

2015-08-17 Thread David Miller
From: Phil Sutter p...@nwl.cc Date: Mon, 17 Aug 2015 23:06:47 +0200 Upon evaluation of IFLA_ADDRESS and IFLA_BROADCAST messages, make sure the passed argument length matches dev-addr_len exactly. This fixes dubious behaviour of 'ip link set eth0 addr MAC' where 'MAC' is too long, e.g.