Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

2018-08-26 Thread Julia Lawall
On Mon, 27 Aug 2018, Al Viro wrote: > On Sun, Aug 26, 2018 at 11:35:17PM -0400, Julia Lawall wrote: > > > * x = \(kmalloc\|kzalloc\|devm_kmalloc\|devm_kzalloc\)(...) > > I can name several you've missed right off the top of my head - > vmalloc, kvmalloc, kmem_cache_alloc, kmem_cache_zalloc,

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

2018-08-26 Thread Al Viro
On Sun, Aug 26, 2018 at 11:35:17PM -0400, Julia Lawall wrote: > * x = \(kmalloc\|kzalloc\|devm_kmalloc\|devm_kzalloc\)(...) I can name several you've missed right off the top of my head - vmalloc, kvmalloc, kmem_cache_alloc, kmem_cache_zalloc, variants with _trace slapped on, and that is not to

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

2018-08-26 Thread Julia Lawall
On Mon, 27 Aug 2018, Al Viro wrote: > On Sun, Aug 26, 2018 at 10:00:46PM -0400, Julia Lawall wrote: > > > > > > On Sun, 26 Aug 2018, Al Viro wrote: > > > > > On Sun, Aug 26, 2018 at 03:26:54PM -0700, Joe Perches wrote: > > > > On Sun, 2018-08-26 at 22:24 +0100, Al Viro wrote: > > > > > On Sun,

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

2018-08-26 Thread Al Viro
On Sun, Aug 26, 2018 at 10:00:46PM -0400, Julia Lawall wrote: > > > On Sun, 26 Aug 2018, Al Viro wrote: > > > On Sun, Aug 26, 2018 at 03:26:54PM -0700, Joe Perches wrote: > > > On Sun, 2018-08-26 at 22:24 +0100, Al Viro wrote: > > > > On Sun, Aug 26, 2018 at 11:57:57AM -0700, Joe Perches wrote:

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

2018-08-26 Thread Julia Lawall
On Sun, 26 Aug 2018, Al Viro wrote: > On Sun, Aug 26, 2018 at 03:26:54PM -0700, Joe Perches wrote: > > On Sun, 2018-08-26 at 22:24 +0100, Al Viro wrote: > > > On Sun, Aug 26, 2018 at 11:57:57AM -0700, Joe Perches wrote: > > > > > > > > That, BTW, is why I hate the use of sizeof(*p) in kmalloc,

Re: [PATCH] net: sched: Fix memory exposure from short TCA_U32_SEL

2018-08-26 Thread Julia Lawall
On Sun, 26 Aug 2018, Joe Perches wrote: > On Sun, 2018-08-26 at 22:24 +0100, Al Viro wrote: > > On Sun, Aug 26, 2018 at 11:57:57AM -0700, Joe Perches wrote: > > > > > > That, BTW, is why I hate the use of sizeof(*p) in kmalloc, etc. > > > > arguments. typeof is even worse in that respect. > >