Re: [PATCH] pktgen: use dynamic allocation for debug print buffer

2018-03-14 Thread Gustavo A. R. Silva
Arnd: Thanks for the fix. On 03/13/2018 10:02 PM, Wang Jian wrote: + kfree(buf); free tb? buf is an array. Wang: Thanks for the report. I already sent a patch to fix this: https://patchwork.kernel.org/patch/10281587/ -- Gustavo On Wed, Mar 14, 2018 at 8:25 AM, David Miller

Re: [PATCH] pktgen: use dynamic allocation for debug print buffer

2018-03-13 Thread Wang Jian
>> + kfree(buf); free tb? buf is an array. On Wed, Mar 14, 2018 at 8:25 AM, David Miller wrote: > From: Arnd Bergmann > Date: Tue, 13 Mar 2018 21:58:39 +0100 > >> After the removal of the VLA, we get a harmless warning about a large >> stack frame: >> >>

Re: [PATCH] pktgen: use dynamic allocation for debug print buffer

2018-03-13 Thread David Miller
From: Arnd Bergmann Date: Tue, 13 Mar 2018 21:58:39 +0100 > After the removal of the VLA, we get a harmless warning about a large > stack frame: > > net/core/pktgen.c: In function 'pktgen_if_write': > net/core/pktgen.c:1710:1: error: the frame size of 1076 bytes is larger than >

[PATCH] pktgen: use dynamic allocation for debug print buffer

2018-03-13 Thread Arnd Bergmann
After the removal of the VLA, we get a harmless warning about a large stack frame: net/core/pktgen.c: In function 'pktgen_if_write': net/core/pktgen.c:1710:1: error: the frame size of 1076 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] The function was previously shown to be safe