Re: [PATCH] r8152: fix lockup when runtime PM is enabled

2015-12-08 Thread Peter Wu
On Tue, Dec 08, 2015 at 03:18:59AM +, Hayes Wang wrote: > Peter Wu > > Sent: Tuesday, December 08, 2015 12:59 AM > [...] > > + if (tp->netdev->flags & IFF_UP) { > > Maybe you could just replace the checking of netif_running(tp->netdev) > with this. Simply replacing

[PATCH] r8152: fix lockup when runtime PM is enabled

2015-12-07 Thread Peter Wu
When an interface is brought up which was previously suspended (via runtime PM), it would hang. This happens because napi_disable is called before napi_enable. Solve this by avoiding napi_disable before the device is fully up. While at it, remove WORK_ENABLE check from rtl8152_open (introduced

RE: [PATCH] r8152: fix lockup when runtime PM is enabled

2015-12-07 Thread Hayes Wang
Peter Wu [mailto:pe...@lekensteyn.nl] > Sent: Tuesday, December 08, 2015 12:59 AM [...] > + if (tp->netdev->flags & IFF_UP) { Maybe you could just replace the checking of netif_running(tp->netdev) with this. Excuse me. I have a question. Before the open() is finished, the