Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

2016-10-01 Thread Jes Sorensen
Joe Perches writes: > On Sat, 2016-10-01 at 16:32 -0400, Jes Sorensen wrote: >> Your output shows it moving to the text segment - if it's in a different >> segment, eg. rodata, you should use output demonstrating that to justify >> the change. > > For size, rodata _is_ text

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

2016-10-01 Thread Joe Perches
On Sat, 2016-10-01 at 16:32 -0400, Jes Sorensen wrote: > Your output shows it moving to the text segment - if it's in a different > segment, eg. rodata, you should use output demonstrating that to justify > the change. For size, rodata _is_ text

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

2016-10-01 Thread Jes Sorensen
Joe Perches writes: > On Sat, 2016-10-01 at 14:53 -0400, Jes Sorensen wrote: >> Joe Perches writes: >> > Make the init arrays const to reduce data. >> > $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o* >> > (allyesconfig: x86-32) >> >   text

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

2016-10-01 Thread Joe Perches
On Sat, 2016-10-01 at 14:53 -0400, Jes Sorensen wrote: > Joe Perches writes: > > Make the init arrays const to reduce data. > > $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o* (allyesconfig: > > x86-32) > >   textdata bss dec hex filename > >  

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

2016-10-01 Thread Jes Sorensen
Joe Perches writes: > Make the init arrays const to reduce data. > > $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o* (allyesconfig: > x86-32) >text data bss dec hex filename > 80107 13651 58 93816 16e78 >

[PATCH] realtek: rtl8xxxu: Use const init arrays

2016-10-01 Thread Joe Perches
Make the init arrays const to reduce data. $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o* (allyesconfig: x86-32) textdata bss dec hex filename 80107 13651 58 93816 16e78 drivers/net/wireless/realtek/rtl8xxxu/built-in.o.new 65303 28435 58 93796