Re: [PATCH] spidernet: checksum and ethtool

2007-06-07 Thread Linas Vepstas
On Tue, May 29, 2007 at 05:24:36PM -0700, Stephen Hemminger wrote: It doesn't look like spidernet hardware can really checksum all protocols, the code looks like it does IPV4 only. If so, it should use NETIF_F_IP_CSUM instead of NETIF_F_HW_CSUM. The driver doesn't need it's own get/set for

[PATCH] spidernet: checksum and ethtool

2007-06-07 Thread Stephen Hemminger
It doesn't look like spidernet hardware can really checksum all protocols, the code looks like it does IPV4 only. If so, it should use NETIF_F_IP_CSUM instead of NETIF_F_HW_CSUM. The driver doesn't need it's own get/set for ethtool tx csum, and it should use the standard ethtool_op_get_link.

Re: [PATCH] spidernet: checksum and ethtool

2007-06-01 Thread Linas Vepstas
On Tue, May 29, 2007 at 05:24:36PM -0700, Stephen Hemminger wrote: It doesn't look like spidernet hardware can really checksum all protocols, the code looks like it does IPV4 only. If so, it should use NETIF_F_IP_CSUM instead of NETIF_F_HW_CSUM. The driver doesn't need it's own get/set for

[PATCH] spidernet: checksum and ethtool

2007-05-29 Thread Stephen Hemminger
It doesn't look like spidernet hardware can really checksum all protocols, the code looks like it does IPV4 only. If so, it should use NETIF_F_IP_CSUM instead of NETIF_F_HW_CSUM. The driver doesn't need it's own get/set for ethtool tx csum, and it should use the standard ethtool_op_get_link.