Re: [PATCH] test_bpf: Fix NULL vs IS_ERR() check in test_skb_segment()

From: Daniel Borkmann Date: Wed, 28 Mar 2018 20:57:27 +0200 > If you have a chance, please take this fix directly into your net-next tree > since it also contains the original commit 76db8087c4c9 ("net: bpf: add a > test for skb_segment in test_bpf module"), which is not in the bpf-next tree > at

Re: [PATCH] test_bpf: Fix NULL vs IS_ERR() check in test_skb_segment()

Hi David, On 03/28/2018 06:19 PM, Yonghong Song wrote: > On 3/28/18 4:48 AM, Dan Carpenter wrote: >> The skb_segment() function returns error pointers on error.  It never >> returns NULL. >> >> Fixes: 76db8087c4c9 ("net: bpf: add a test for skb_segment in test_bpf >> module") >> Signed-off-by: Da

Re: [PATCH] test_bpf: Fix NULL vs IS_ERR() check in test_skb_segment()

On 3/28/18 4:48 AM, Dan Carpenter wrote: The skb_segment() function returns error pointers on error. It never returns NULL. Fixes: 76db8087c4c9 ("net: bpf: add a test for skb_segment in test_bpf module") Signed-off-by: Dan Carpenter diff --git a/lib/test_bpf.c b/lib/test_bpf.c index b2badf6

Re: [PATCH] test_bpf: Fix NULL vs IS_ERR() check in test_skb_segment()

On 03/28/2018 01:48 PM, Dan Carpenter wrote: > The skb_segment() function returns error pointers on error. It never > returns NULL. > > Fixes: 76db8087c4c9 ("net: bpf: add a test for skb_segment in test_bpf > module") > Signed-off-by: Dan Carpenter Patch is directly for net-next, thanks! Acke

[PATCH] test_bpf: Fix NULL vs IS_ERR() check in test_skb_segment()

The skb_segment() function returns error pointers on error. It never returns NULL. Fixes: 76db8087c4c9 ("net: bpf: add a test for skb_segment in test_bpf module") Signed-off-by: Dan Carpenter diff --git a/lib/test_bpf.c b/lib/test_bpf.c index b2badf6b23cd..8e157806df7a 100644 --- a/lib/test_bpf