Re: [PATCH] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-02-11 Thread Vijay Pandurangan
Just as a followup, I wrote a short blog detailing the bug and our resolution: (https://twitter.com/vijayp/status/697837808417779716) Thanks again for your help in guiding us through our first kernel patch. This was a great experience! direct link:

Re: [PATCH] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2015-12-23 Thread Cong Wang
On Tue, Dec 22, 2015 at 11:37 PM, Vijay Pandurangan wrote: > Cool, thanks! I see it in the -stable queue. Is there anything else I need > to do to help with getting this into main or backporting? Happy to pitch in > if I can be helpful. > DaveM usually just backports it to a

Re: [PATCH] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2015-12-22 Thread David Miller
From: Vijay Pandurangan Date: Fri, 18 Dec 2015 14:34:59 -0500 > Packets that arrive from real hardware devices have ip_summed == > CHECKSUM_UNNECESSARY if the hardware verified the checksums, or > CHECKSUM_NONE if the packet is bad or it was unable to verify it. The > current

Re: [PATCH] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2015-12-19 Thread Cong Wang
On Fri, Dec 18, 2015 at 11:34 AM, Vijay Pandurangan wrote: > Packets that arrive from real hardware devices have ip_summed == > CHECKSUM_UNNECESSARY if the hardware verified the checksums, or > CHECKSUM_NONE if the packet is bad or it was unable to verify it. The > current

[PATCH] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2015-12-18 Thread Vijay Pandurangan
Packets that arrive from real hardware devices have ip_summed == CHECKSUM_UNNECESSARY if the hardware verified the checksums, or CHECKSUM_NONE if the packet is bad or it was unable to verify it. The current version of veth will replace CHECKSUM_NONE with CHECKSUM_UNNECESSARY, which causes corrupt