Re: [PATCH] wlcore: time sync : add support for 64 bit clock

2016-06-23 Thread Johannes Berg
> > Additionally, this looks like it changes the firmware API, so that  > > older firmware images will no longer work? > > It is backwards compatible,  > although it changes a API structure, older firmware are using only > u16 for the field so there is no impact on that. > Oh, ok. I had also

RE: [PATCH] wlcore: time sync : add support for 64 bit clock

2016-06-23 Thread Machani, Yaniv
On Thu, Jun 23, 2016 at 14:18:00, Johannes Berg wrote: > linux-wirel...@vger.kernel.org; netdev@vger.kernel.org > Subject: Re: [PATCH] wlcore: time sync : add support for 64 bit clock > > On Thu, 2016-06-23 at 14:12 +0300, Yaniv Machani wrote: > > Changed the configuratio

Re: [PATCH] wlcore: time sync : add support for 64 bit clock

2016-06-23 Thread Johannes Berg
On Thu, 2016-06-23 at 14:12 +0300, Yaniv Machani wrote: > Changed the configuration to support 64bit instead of 32bit > this in order to offload the driver from handling a wraparound. [...] Since you Cc'ed me, and presumably want me to review it, I'll say that this looks like a terrible idea: >

[PATCH] wlcore: time sync : add support for 64 bit clock

2016-06-23 Thread Yaniv Machani
Changed the configuration to support 64bit instead of 32bit this in order to offload the driver from handling a wraparound. Signed-off-by: Yaniv Machani --- drivers/net/wireless/ti/wl18xx/event.c | 26 +- drivers/net/wireless/ti/wl18xx/event.h | 19