Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode
On Mon, Jul 31, 2017 at 08:19:40PM +0800, Chen-Yu Tsai wrote: > On Sat, Jul 29, 2017 at 2:48 PM, Corentin Labbe >wrote: > > On Fri, Jul 28, 2017 at 10:54:30AM -0700, Florian Fainelli wrote: > >> On 07/28/2017 07:44 AM, Corentin Labbe wrote: > >> > On Fri, Jul 28, 2017 at 04:36:00PM +0200, Andrew Lunn wrote: > >> I've probably asked this before: Does the internal PHY use a different > >> PHY ID in registers 2 and 3? > >> > >> >>> > >> >>> yes > >> >>> > >> >>> reg2: 0x0044 > >> >>> reg3: 0X1500 > >> > > >> > Copy/paste error, its 1400 > >> > > >> >> > >> >> So this is not about loading the correct PHY driver. You can already > >> >> do this based on the PHY IDs... > >> >> > >> >> This is about selecting which PHY to use. Internal or External? > >> >> > >> >> Andrew > >> > > >> > It is too late when we know the PHY ID. > >> > >> > We need to set a syscon for choosing external/internal PHY. > >> > So we can rely only on DT. > >> > >> Since the Device Tree needs to be correct to identify which PHY to use > >> (internal or external), if you use the standard compatible string for > >> the PHY that contains its OUI, e.g: > >> > >> compatible = "ethernet-phy-id0044.1400", "ethernet-phy-ieee802.3-c22" > >> > >> then you can have your Ethernet MAC identify whether this is an internal > >> PHY by having a list of compatible strings to match against. > > > > So basicly, I replace sun8i-h3-ephy by ethernet-phy-id0044.1400 and it is > > good ? > > IIRC you mentioned some time ago the PHY in the AC200 also has this ID? > Do you remember if this is true? Yes it's certainly a AC200 PHY in the H3. > > If someone were crazy enough to hook that up to the H3, then we still > wouldn't be able to tell if it's the internal or external one. > Why someone would put the same external PHY than the internal one ? Yeah its totally crazy and I think we are safe by saying "it's not supported". Regards
Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode
On Sat, Jul 29, 2017 at 2:48 PM, Corentin Labbewrote: > On Fri, Jul 28, 2017 at 10:54:30AM -0700, Florian Fainelli wrote: >> On 07/28/2017 07:44 AM, Corentin Labbe wrote: >> > On Fri, Jul 28, 2017 at 04:36:00PM +0200, Andrew Lunn wrote: >> I've probably asked this before: Does the internal PHY use a different >> PHY ID in registers 2 and 3? >> >> >>> >> >>> yes >> >>> >> >>> reg2: 0x0044 >> >>> reg3: 0X1500 >> > >> > Copy/paste error, its 1400 >> > >> >> >> >> So this is not about loading the correct PHY driver. You can already >> >> do this based on the PHY IDs... >> >> >> >> This is about selecting which PHY to use. Internal or External? >> >> >> >> Andrew >> > >> > It is too late when we know the PHY ID. >> >> > We need to set a syscon for choosing external/internal PHY. >> > So we can rely only on DT. >> >> Since the Device Tree needs to be correct to identify which PHY to use >> (internal or external), if you use the standard compatible string for >> the PHY that contains its OUI, e.g: >> >> compatible = "ethernet-phy-id0044.1400", "ethernet-phy-ieee802.3-c22" >> >> then you can have your Ethernet MAC identify whether this is an internal >> PHY by having a list of compatible strings to match against. > > So basicly, I replace sun8i-h3-ephy by ethernet-phy-id0044.1400 and it is > good ? IIRC you mentioned some time ago the PHY in the AC200 also has this ID? Do you remember if this is true? If someone were crazy enough to hook that up to the H3, then we still wouldn't be able to tell if it's the internal or external one. ChenYu > >> >> Corentin, can you make sure you copy netdev, Andrew and myself on the >> next submissions so we don't have to keep track of seemingly identical >> threads (this one + the rockchip dwmac changes) and we can work towards >> one solution? > > Ok > > Thanks > Corentin Labbe
Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode
On Fri, Jul 28, 2017 at 10:54:30AM -0700, Florian Fainelli wrote: > On 07/28/2017 07:44 AM, Corentin Labbe wrote: > > On Fri, Jul 28, 2017 at 04:36:00PM +0200, Andrew Lunn wrote: > I've probably asked this before: Does the internal PHY use a different > PHY ID in registers 2 and 3? > > >>> > >>> yes > >>> > >>> reg2: 0x0044 > >>> reg3: 0X1500 > > > > Copy/paste error, its 1400 > > > >> > >> So this is not about loading the correct PHY driver. You can already > >> do this based on the PHY IDs... > >> > >> This is about selecting which PHY to use. Internal or External? > >> > >> Andrew > > > > It is too late when we know the PHY ID. > > > We need to set a syscon for choosing external/internal PHY. > > So we can rely only on DT. > > Since the Device Tree needs to be correct to identify which PHY to use > (internal or external), if you use the standard compatible string for > the PHY that contains its OUI, e.g: > > compatible = "ethernet-phy-id0044.1400", "ethernet-phy-ieee802.3-c22" > > then you can have your Ethernet MAC identify whether this is an internal > PHY by having a list of compatible strings to match against. So basicly, I replace sun8i-h3-ephy by ethernet-phy-id0044.1400 and it is good ? > > Corentin, can you make sure you copy netdev, Andrew and myself on the > next submissions so we don't have to keep track of seemingly identical > threads (this one + the rockchip dwmac changes) and we can work towards > one solution? Ok Thanks Corentin Labbe
Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode
On 07/28/2017 07:44 AM, Corentin Labbe wrote: > On Fri, Jul 28, 2017 at 04:36:00PM +0200, Andrew Lunn wrote: I've probably asked this before: Does the internal PHY use a different PHY ID in registers 2 and 3? >>> >>> yes >>> >>> reg2: 0x0044 >>> reg3: 0X1500 > > Copy/paste error, its 1400 > >> >> So this is not about loading the correct PHY driver. You can already >> do this based on the PHY IDs... >> >> This is about selecting which PHY to use. Internal or External? >> >> Andrew > > It is too late when we know the PHY ID. > We need to set a syscon for choosing external/internal PHY. > So we can rely only on DT. Since the Device Tree needs to be correct to identify which PHY to use (internal or external), if you use the standard compatible string for the PHY that contains its OUI, e.g: compatible = "ethernet-phy-id0044.1400", "ethernet-phy-ieee802.3-c22" then you can have your Ethernet MAC identify whether this is an internal PHY by having a list of compatible strings to match against. Corentin, can you make sure you copy netdev, Andrew and myself on the next submissions so we don't have to keep track of seemingly identical threads (this one + the rockchip dwmac changes) and we can work towards one solution? Thanks -- Florian
Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode
> It is too late when we know the PHY ID. > We need to set a syscon for choosing external/internal PHY. > So we can rely only on DT. The point is, its not a property of the PHY. It is a syscon or a MAC property. Having it as a MAC property would be more generic. Andrew
Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode
On Fri, Jul 28, 2017 at 04:36:00PM +0200, Andrew Lunn wrote: > > > I've probably asked this before: Does the internal PHY use a different > > > PHY ID in registers 2 and 3? > > > > > > > yes > > > > reg2: 0x0044 > > reg3: 0X1500 Copy/paste error, its 1400 > > So this is not about loading the correct PHY driver. You can already > do this based on the PHY IDs... > > This is about selecting which PHY to use. Internal or External? > > Andrew It is too late when we know the PHY ID. We need to set a syscon for choosing external/internal PHY. So we can rely only on DT.
Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode
> > I've probably asked this before: Does the internal PHY use a different > > PHY ID in registers 2 and 3? > > > > yes > > reg2: 0x0044 > reg3: 0X1500 So this is not about loading the correct PHY driver. You can already do this based on the PHY IDs... This is about selecting which PHY to use. Internal or External? Andrew
Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode
On Fri, Jul 28, 2017 at 03:55:44PM +0200, Andrew Lunn wrote: > On Fri, Jul 28, 2017 at 11:28:15AM +0200, Corentin Labbe wrote: > > Hello > > > > The current way to find if the phy is internal is to compare DT phy-mode > > and emac_variant/internal_phy. > > But it will negate a possible future SoC where an external PHY use the > > same phy mode than the internal one. > > > > This patchs series adds a new way to find if the PHY is internal, via its > > compatible. > > http://elixir.free-electrons.com/linux/latest/source/drivers/of/of_mdio.c#L144 > > Since you also have "ethernet-phy-ieee802.3-c22", you won't get the > warning. But still, your device tree gives the wrong idea. > > I've probably asked this before: Does the internal PHY use a different > PHY ID in registers 2 and 3? > yes reg2: 0x0044 reg3: 0X1500 Regards
Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode
On Fri, Jul 28, 2017 at 11:28:15AM +0200, Corentin Labbe wrote: > Hello > > The current way to find if the phy is internal is to compare DT phy-mode > and emac_variant/internal_phy. > But it will negate a possible future SoC where an external PHY use the > same phy mode than the internal one. > > This patchs series adds a new way to find if the PHY is internal, via its > compatible. http://elixir.free-electrons.com/linux/latest/source/drivers/of/of_mdio.c#L144 Since you also have "ethernet-phy-ieee802.3-c22", you won't get the warning. But still, your device tree gives the wrong idea. I've probably asked this before: Does the internal PHY use a different PHY ID in registers 2 and 3? Andrew
Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode
On Fri, Jul 28, 2017 at 05:53:40PM +0800, Chen-Yu Tsai wrote: > On Fri, Jul 28, 2017 at 5:28 PM, Corentin Labbe >wrote: > > Hello > > > > The current way to find if the phy is internal is to compare DT phy-mode > > and emac_variant/internal_phy. > > But it will negate a possible future SoC where an external PHY use the > > same phy mode than the internal one. > > > > This patchs series adds a new way to find if the PHY is internal, via its > > compatible. > > You've already joined in on the discussion for the patch "net: stmmac: > dwmac-rk: Add internal phy support". It is pretty much the same issue. > Please wait for it to come to a proper conclusion. At least then we can > agree on something so different platforms with the same problem don't > have diverging solutions. Yes, this is important. Andrew
Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode
On Fri, Jul 28, 2017 at 5:28 PM, Corentin Labbewrote: > Hello > > The current way to find if the phy is internal is to compare DT phy-mode > and emac_variant/internal_phy. > But it will negate a possible future SoC where an external PHY use the > same phy mode than the internal one. > > This patchs series adds a new way to find if the PHY is internal, via its > compatible. You've already joined in on the discussion for the patch "net: stmmac: dwmac-rk: Add internal phy support". It is pretty much the same issue. Please wait for it to come to a proper conclusion. At least then we can agree on something so different platforms with the same problem don't have diverging solutions. ChenYu > > Corentin Labbe (3): > dt-bindings: net: add compatible for internal sun8i-h3/sun8i-v3s PHYs > ARM: sunxi: h3/h5: Add sun8i-h3-ephy compatible > net-next: stmmac: dwmac-sun8i: choose internal PHY via compatible > > Documentation/devicetree/bindings/net/dwmac-sun8i.txt | 4 ++-- > arch/arm/boot/dts/sunxi-h3-h5.dtsi| 3 ++- > drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 16 ++-- > 3 files changed, 14 insertions(+), 9 deletions(-) > > -- > 2.13.0 >
[PATCH 0/3] net-next: stmmac: support future possible different internal phy mode
Hello The current way to find if the phy is internal is to compare DT phy-mode and emac_variant/internal_phy. But it will negate a possible future SoC where an external PHY use the same phy mode than the internal one. This patchs series adds a new way to find if the PHY is internal, via its compatible. Corentin Labbe (3): dt-bindings: net: add compatible for internal sun8i-h3/sun8i-v3s PHYs ARM: sunxi: h3/h5: Add sun8i-h3-ephy compatible net-next: stmmac: dwmac-sun8i: choose internal PHY via compatible Documentation/devicetree/bindings/net/dwmac-sun8i.txt | 4 ++-- arch/arm/boot/dts/sunxi-h3-h5.dtsi| 3 ++- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 16 ++-- 3 files changed, 14 insertions(+), 9 deletions(-) -- 2.13.0