Re: [PATCH 0/5 net-next v2] ibmvnic: LPM bug fixes
From: Thomas Falcon Date: Wed, 14 Jun 2017 23:50:04 -0500 > This series of small patches is meant to resolve a number of > bugs, mostly occurring during an ibmvnic driver reset when > recovering from a logical partition migration (LPM). > > The first patch ensures that RX buffer pools are properly > activated following an adapter reset by setting the proper > flag in the pool data structure. > > The second patch uses netif_tx_disable to stop TX queues when > closing the device during a reset. > > Third, fixup a typo that resulted in partial sanitization of > TX/RX descriptor queues following a device reset. > > Fourth, remove an ambiguous conditional check that was resulting > in a kernel panic as null RX/TX completion descriptors were being > processed during napi polling while the device is closing. > > Finally, fix a condition where the napi polling routine exits > before it has completed its work budget without notifying the > upper network layers. This omission could result in the > napi_disable function sleeping indefinitely under certain conditions. > > v2: Attempt to provide a proper cover letter Series applied, thank you.
[PATCH 0/5 net-next v2] ibmvnic: LPM bug fixes
This series of small patches is meant to resolve a number of bugs, mostly occurring during an ibmvnic driver reset when recovering from a logical partition migration (LPM). The first patch ensures that RX buffer pools are properly activated following an adapter reset by setting the proper flag in the pool data structure. The second patch uses netif_tx_disable to stop TX queues when closing the device during a reset. Third, fixup a typo that resulted in partial sanitization of TX/RX descriptor queues following a device reset. Fourth, remove an ambiguous conditional check that was resulting in a kernel panic as null RX/TX completion descriptors were being processed during napi polling while the device is closing. Finally, fix a condition where the napi polling routine exits before it has completed its work budget without notifying the upper network layers. This omission could result in the napi_disable function sleeping indefinitely under certain conditions. v2: Attempt to provide a proper cover letter Thomas Falcon (5): ibmvnic: Activate disabled RX buffer pools on reset ibmvnic: Ensure that TX queues are disabled in __ibmvnic_close ibmvnic: Sanitize entire SCRQ buffer on reset ibmvnic: Remove VNIC_CLOSING check from pending_scrq ibmvnic: Exit polling routine correctly during adapter reset drivers/net/ethernet/ibm/ibmvnic.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) -- 1.8.3.1
