Re: [PATCH 02/12] treewide/net: Rename eth_stp_addr to ether_stp_addr

2018-03-31 Thread kbuild test robot
Hi Joe, I love your patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.16-rc7 next-20180329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 02/12] treewide/net: Rename eth_stp_addr to ether_stp_addr

2018-03-31 Thread Joe Perches
On Sat, 2018-03-31 at 19:36 +0200, Andrew Lunn wrote: > On Sat, Mar 31, 2018 at 12:05:17AM -0700, Joe Perches wrote: > > --- a/net/bridge/br_device.c > > +++ b/net/bridge/br_device.c > > @@ -1,4 +1,4 @@ > > -/* > > +gg/* > > Hi Joe > > This does not look good. Definitely agree with that.

Re: [PATCH 02/12] treewide/net: Rename eth_stp_addr to ether_stp_addr

2018-03-31 Thread Andrew Lunn
On Sat, Mar 31, 2018 at 12:05:17AM -0700, Joe Perches wrote: > --- a/net/bridge/br_device.c > +++ b/net/bridge/br_device.c > @@ -1,4 +1,4 @@ > -/* > +gg/* Hi Joe This does not look good. Andrew

[PATCH 02/12] treewide/net: Rename eth_stp_addr to ether_stp_addr

2018-03-31 Thread Joe Perches
eth_stp_addr is not in the same form as the other global ether__addr addresses like ether_broadcast_addr. Convert it treewide. Miscellanea: o Add comment to the ether_stp_addr define to show it's for spanning-tree Signed-off-by: Joe Perches ---