Re: [PATCH 04/11] IB/cm: Expose DGID in SIDR request events

2015-06-18 Thread Haggai Eran
On 17/06/2015 20:06, Jason Gunthorpe wrote: On Tue, Jun 16, 2015 at 02:25:07PM +0300, Haggai Eran wrote: Regarding APM, currently the ib_cm code always sends the GMP to the primary path anyway, right? And in any case, one would expect the primary path's GID to have a valid net_device and

Re: [PATCH 04/11] IB/cm: Expose DGID in SIDR request events

2015-06-17 Thread Haggai Eran
On Tuesday, June 16, 2015 7:47 PM, Hefty, Sean sean.he...@intel.com wrote: To: Haggai Eran; Doug Ledford Cc: linux-r...@vger.kernel.org; netdev@vger.kernel.org; Liran Liss; Guy Shapiro; Shachar Raindel; Yotam Kenneth; Jason Gunthorpe Subject: RE: [PATCH 04/11] IB/cm: Expose DGID in SIDR

Re: [PATCH 04/11] IB/cm: Expose DGID in SIDR request events

2015-06-17 Thread Jason Gunthorpe
On Tue, Jun 16, 2015 at 02:25:07PM +0300, Haggai Eran wrote: But how is that going to work? How is the sender to know it should be sending a GRH with the CM message? If the admin wants to use SIDR with alias GIDs, they will need to configure the system to enable GRH for such GMPs. (This

RE: [PATCH 04/11] IB/cm: Expose DGID in SIDR request events

2015-06-16 Thread Hefty, Sean
The idea is to allow SIDR request to be sorted by the GID, when we will have alias GIDs for IPoIB. Please limit this series, or at least the early patches in this series, to simply moving the de-mux out of the ib_cm and into the rdma_cm. -- To unsubscribe from this list: send the line

Re: [PATCH 04/11] IB/cm: Expose DGID in SIDR request events

2015-06-16 Thread Haggai Eran
On 16/06/2015 00:32, Hefty, Sean wrote: drivers/infiniband/core/cm.c | 7 +++ include/rdma/ib_cm.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c index c5f5f89e274a..46f99ec4080a 100644 ---

Re: [PATCH 04/11] IB/cm: Expose DGID in SIDR request events

2015-06-16 Thread Haggai Eran
On 16/06/2015 01:08, Jason Gunthorpe wrote: On Mon, Jun 15, 2015 at 09:32:53PM +, Hefty, Sean wrote: drivers/infiniband/core/cm.c | 7 +++ include/rdma/ib_cm.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c

[PATCH 04/11] IB/cm: Expose DGID in SIDR request events

2015-06-15 Thread Haggai Eran
The destination GID can be used to uniquely resolve the request. Expose the GID in SIDR request events when it is available, so that the rdma_cm module can use that information. Signed-off-by: Haggai Eran hagg...@mellanox.com --- drivers/infiniband/core/cm.c | 7 +++ include/rdma/ib_cm.h

RE: [PATCH 04/11] IB/cm: Expose DGID in SIDR request events

2015-06-15 Thread Hefty, Sean
drivers/infiniband/core/cm.c | 7 +++ include/rdma/ib_cm.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c index c5f5f89e274a..46f99ec4080a 100644 --- a/drivers/infiniband/core/cm.c +++

Re: [PATCH 04/11] IB/cm: Expose DGID in SIDR request events

2015-06-15 Thread Jason Gunthorpe
On Mon, Jun 15, 2015 at 09:32:53PM +, Hefty, Sean wrote: drivers/infiniband/core/cm.c | 7 +++ include/rdma/ib_cm.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c index c5f5f89e274a..46f99ec4080a