Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel

2015-07-24 Thread Kalle Valo
Maninder Singh maninder...@samsung.com writes: chandef is initialized with NULL and on the very next line, we are using it to get channel, which is not correct. channel should be initialized after obtaining chandef. Signed-off-by: Maninder Singh maninder...@samsung.com Thanks, applied. --

Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel

2015-07-21 Thread Kalle Valo
Maninder Singh maninder...@samsung.com writes: chandef is initialized with NULL and on the very next line, we are using it to get channel, which is not correct. channel should be initialized after obtaining chandef. Signed-off-by: Maninder Singh maninder...@samsung.com How did you find

Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel

2015-07-21 Thread Kalle Valo
Maninder Singh maninder...@samsung.com writes: chandef is initialized with NULL and on the very next line, we are using it to get channel, which is not correct. channel should be initialized after obtaining chandef. Signed-off-by: Maninder Singh maninder...@samsung.com How did you find

Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel

2015-07-21 Thread Maninder Singh
chandef is initialized with NULL and on the very next line, we are using it to get channel, which is not correct. channel should be initialized after obtaining chandef. Signed-off-by: Maninder Singh maninder...@samsung.com How did you find this bug? Static anlysis reports this bug like

[PATCH 1/1] ath10k: fixing wrong initialization of struct channel

2015-07-15 Thread Maninder Singh
chandef is initialized with NULL and on the very next line, we are using it to get channel, which is not correct. channel should be initialized after obtaining chandef. Signed-off-by: Maninder Singh maninder...@samsung.com --- drivers/net/wireless/ath/ath10k/mac.c |2 +- 1 file changed, 1