Re: [PATCH 1/1] sysctl to allow TCP window > 32767 sans wscale

2006-03-09 Thread David S. Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Thu, 09 Mar 2006 15:34:33 -0800 > David S. Miller wrote: > > I had to do some minor fixups, and kill some trailing whitespace > > added by this patch, but looks good, applied. > > > > Thanks a lot Rick. > > You're welcome. If the fixups were related to

Re: [PATCH 1/1] sysctl to allow TCP window > 32767 sans wscale

2006-03-09 Thread Rick Jones
David S. Miller wrote: I had to do some minor fixups, and kill some trailing whitespace added by this patch, but looks good, applied. Thanks a lot Rick. You're welcome. If the fixups were related to things I may have botched in the patch process, please let me know so I might be able to avoi

Re: [PATCH 1/1] sysctl to allow TCP window > 32767 sans wscale

2006-03-09 Thread David S. Miller
I had to do some minor fixups, and kill some trailing whitespace added by this patch, but looks good, applied. Thanks a lot Rick. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majord

[PATCH 1/1] sysctl to allow TCP window > 32767 sans wscale

2006-03-09 Thread Rick Jones
--- linux-2.6-2.6.15/net/ipv4/tcp_output.c.orig 2006-01-02 19:21:10.0 -0800 +++ linux-2.6-2.6.15/net/ipv4/tcp_output.c 2006-03-09 10:41:46.0 -0800 @@ -45,6 +45,11 @@ /* People can turn this off for buggy TCP's found in printers etc. */ int sysctl_tcp_retrans_collapse = 1;

Re: [PATCH 1/1] sysctl to allow TCP window > 32767 sans wscale

2006-03-09 Thread Rick Jones
Ok, I've heard your arguments, let's allow full 16-bit windows by default in 2.6.17, but please pick a better name for the sysctl knob :-) How about something like "tcp_workaround_signed_windows"? So make the naming change, and allow full 16-bit windows by default, and I'll apply this patch. O

Re: [PATCH 1/1] sysctl to allow TCP window > 32767 sans wscale

2006-03-09 Thread David S. Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Tue, 7 Mar 2006 13:50:59 -0800 (PST) > Since such stacks are rapidly fading into the mists of time, and since > it is perfectly legal and not entirely uncommon to use a TCP window up > to 65535 bytes when window scaling is not in use, we want to allow an

[PATCH 1/1] sysctl to allow TCP window > 32767 sans wscale

2006-03-07 Thread Rick Jones
Provide a sysctl called "tcp_tape_broken_windows" to disable limiting the advertised TCP window to 32767 bytes when the remote has not sent us a window scale option. Long long ago and far away, there were it seems some broken TCP stacks which mistakenly treated the 16 bit TCP window field as a sig