Re: [PATCH 1/2] netdevice: add netdev_pub helper function

2017-07-10 Thread Jason A. Donenfeld
On Mon, Jul 10, 2017 at 10:04 AM, David Miller wrote: > I disagree. Assuming one can go from the driver private to the netdev > object trivially is a worse assumption than the other way around, and > locks us into the current implementation of how the netdev and driver > private memory is allocat

Re: [PATCH 1/2] netdevice: add netdev_pub helper function

2017-07-10 Thread David Miller
From: "Jason A. Donenfeld" Date: Mon, 10 Jul 2017 05:19:58 +0200 > Being able to utilize this makes code a lot simpler and cleaner. It's > easier in many cases for drivers to pass around their private data > structure, while occationally needing to dip into net_device, rather > than the other way

[PATCH 1/2] netdevice: add netdev_pub helper function

2017-07-09 Thread Jason A. Donenfeld
Being able to utilize this makes code a lot simpler and cleaner. It's easier in many cases for drivers to pass around their private data structure, while occationally needing to dip into net_device, rather than the other way around, which results in tons of calls to netdev_priv in the top of every