Re: [PATCH 1/5] net: remove bogus RCU annotations on socket.wq

2018-07-30 Thread David Miller
From: Christoph Hellwig Date: Mon, 30 Jul 2018 09:44:54 +0200 > On Sun, Jul 29, 2018 at 01:05:51PM -0700, David Miller wrote: >> From: Christoph Hellwig >> Date: Fri, 27 Jul 2018 16:02:10 +0200 >> >> > We never use RCU protection for it, just a lot of cargo-cult >> > rcu_deference_protects

Re: [PATCH 1/5] net: remove bogus RCU annotations on socket.wq

2018-07-30 Thread Christoph Hellwig
On Sun, Jul 29, 2018 at 01:05:51PM -0700, David Miller wrote: > From: Christoph Hellwig > Date: Fri, 27 Jul 2018 16:02:10 +0200 > > > We never use RCU protection for it, just a lot of cargo-cult > > rcu_deference_protects calls. > > > > Note that we do keep the kfree_rcu call for it, as the

Re: [PATCH 1/5] net: remove bogus RCU annotations on socket.wq

2018-07-29 Thread David Miller
From: Christoph Hellwig Date: Fri, 27 Jul 2018 16:02:10 +0200 > We never use RCU protection for it, just a lot of cargo-cult > rcu_deference_protects calls. > > Note that we do keep the kfree_rcu call for it, as the references through > struct sock are RCU protected and thus might require a

[PATCH 1/5] net: remove bogus RCU annotations on socket.wq

2018-07-27 Thread Christoph Hellwig
We never use RCU protection for it, just a lot of cargo-cult rcu_deference_protects calls. Note that we do keep the kfree_rcu call for it, as the references through struct sock are RCU protected and thus might require a grace period before freeing. Signed-off-by: Christoph Hellwig ---