Re: [PATCH 10/21] r8169: merge with version 6.001.00 of Realtek's r8169 driver

2007-06-30 Thread Francois Romieu
Jeff Garzik [EMAIL PROTECTED] : Arjan van de Ven wrote: + pci_write_config_byte(tp-pci_dev, PCI_LATENCY_TIMER, 0x40); can you create a pci_set_latency_timer() for this please? [...] + if (tp-mac_version = RTL_GIGA_MAC_VER_06) + pci_write_config_byte(tp-pci_dev,

Re: [PATCH 10/21] r8169: merge with version 6.001.00 of Realtek's r8169 driver

2007-06-30 Thread Jeff Garzik
Francois Romieu wrote: Jeff Garzik [EMAIL PROTECTED] : Arjan van de Ven wrote: + pci_write_config_byte(tp-pci_dev, PCI_LATENCY_TIMER, 0x40); can you create a pci_set_latency_timer() for this please? [...] + if (tp-mac_version = RTL_GIGA_MAC_VER_06) +

Re: [PATCH 10/21] r8169: merge with version 6.001.00 of Realtek's r8169 driver

2007-06-30 Thread Arjan van de Ven
On Sat, 2007-06-30 at 05:47 -0400, Jeff Garzik wrote: Francois Romieu wrote: Jeff Garzik [EMAIL PROTECTED] : Arjan van de Ven wrote: +pci_write_config_byte(tp-pci_dev, PCI_LATENCY_TIMER, 0x40); can you create a pci_set_latency_timer() for this please? [...] +if

[PATCH 10/21] r8169: merge with version 6.001.00 of Realtek's r8169 driver

2007-06-29 Thread Francois Romieu
- new identifier for the 8110SCe - the PCI latency timer is set unconditionally. This part is identical in Realtek's r8168 (8.001.00) and r8101 (1.001.00) - initialization of the cache line size register is for the 8169s only - more magic in rtl_hw_start_8169 - it is not possible to factor

Re: [PATCH 10/21] r8169: merge with version 6.001.00 of Realtek's r8169 driver

2007-06-29 Thread Arjan van de Ven
+ pci_write_config_byte(tp-pci_dev, PCI_LATENCY_TIMER, 0x40); can you create a pci_set_latency_timer() for this please? + + if (tp-mac_version = RTL_GIGA_MAC_VER_06) + pci_write_config_byte(tp-pci_dev, PCI_CACHE_LINE_SIZE, 0x08); and something for this as well? - To

Re: [PATCH 10/21] r8169: merge with version 6.001.00 of Realtek's r8169 driver

2007-06-29 Thread Jeff Garzik
Arjan van de Ven wrote: + pci_write_config_byte(tp-pci_dev, PCI_LATENCY_TIMER, 0x40); can you create a pci_set_latency_timer() for this please? + + if (tp-mac_version = RTL_GIGA_MAC_VER_06) + pci_write_config_byte(tp-pci_dev, PCI_CACHE_LINE_SIZE, 0x08); and