[PATCH 13/17] batman-adv: Consume skb in receive handlers

From: Sven Eckelmann Receiving functions in Linux consume the supplied skbuff. Doing the same in the batadv_rx_handler functions makes the behavior more similar to the rest of the Linux network code. Signed-off-by: Sven Eckelmann Signed-off-by: Simon

Re: [PATCH 13/17] batman-adv: Consume skb in receive handlers

On Dienstag, 8. November 2016 09:43:01 CET Eric Dumazet wrote: [...] > Sure, but your patch 13/17 should address this right away. [...] Fair enough. I've asked Simon to resubmit the patches with the "consume_skb -> conditional kfree_skb/consume_skb" patch squashed into patch 13. Kind regards,

Re: [PATCH 13/17] batman-adv: Consume skb in receive handlers

On Tue, 2016-11-08 at 18:28 +0100, Sven Eckelmann wrote: > On Dienstag, 8. November 2016 08:59:49 CET Eric Dumazet wrote: > [...] > > > +free_skb: > > > consume_skb(skb); > > > - return NET_RX_SUCCESS; > > > + > > > + return ret; > > > } > > > > > > Okay, but we do have kfree_skb() and

Re: [PATCH 13/17] batman-adv: Consume skb in receive handlers

On Dienstag, 8. November 2016 08:59:49 CET Eric Dumazet wrote: [...] > > +free_skb: > > consume_skb(skb); > > - return NET_RX_SUCCESS; > > + > > + return ret; > > } > > > Okay, but we do have kfree_skb() and consume_skb() and they should be > used appropriately. Yes, this patch is one

Re: [PATCH 13/17] batman-adv: Consume skb in receive handlers

On Tue, 2016-11-08 at 17:45 +0100, Simon Wunderlich wrote: > From: Sven Eckelmann > > Receiving functions in Linux consume the supplied skbuff. Doing the same in > the batadv_rx_handler functions makes the behavior more similar to the rest > of the Linux network code. > >

[PATCH 13/17] batman-adv: Consume skb in receive handlers

From: Sven Eckelmann Receiving functions in Linux consume the supplied skbuff. Doing the same in the batadv_rx_handler functions makes the behavior more similar to the rest of the Linux network code. Signed-off-by: Sven Eckelmann Signed-off-by: Simon