Re: [PATCH 2/2] atm: solos-pci: constify attribute_group structures

[David Miller]

From: Amitoj Kaur Chawla 
Date: Tue, 1 Aug 2017 19:57:47 -0400

> Functions working with attribute_groups provided by 
> work with const attribute_group. These attribute_group structures do not
> change at runtime so mark them as const.
> 
> File size before:
>  text  data bss dec hex filename
>  3574028424 832   64996fde4 drivers/atm/solos-pci.o
> 
> File size after:
>  text  data bss dec hex filename
>  3593228232 832   64996fde4 drivers/atm/solos-pci.o
> 
> This change was made with the help of Coccinelle.
> 
> Signed-off-by: Amitoj Kaur Chawla 

Applied.

[PATCH 2/2] atm: solos-pci: constify attribute_group structures

[Amitoj Kaur Chawla]

Functions working with attribute_groups provided by 
work with const attribute_group. These attribute_group structures do not
change at runtime so mark them as const.

File size before:
 text  data bss dec hex filename
 3574028424 832   64996fde4 drivers/atm/solos-pci.o

File size after:
 text  data bss dec hex filename
 3593228232 832   64996fde4 drivers/atm/solos-pci.o

This change was made with the help of Coccinelle.

Signed-off-by: Amitoj Kaur Chawla 
---
 drivers/atm/solos-pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index c8f2ca6..3f9c37d 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -611,7 +611,7 @@ static struct attribute *solos_attrs[] = {
NULL
 };
 
-static struct attribute_group solos_attr_group = {
+static const struct attribute_group solos_attr_group = {
.attrs = solos_attrs,
.name = "parameters",
 };
@@ -628,7 +628,7 @@ static struct attribute *gpio_attrs[] = {
NULL
 };
 
-static struct attribute_group gpio_attr_group = {
+static const struct attribute_group gpio_attr_group = {
.attrs = gpio_attrs,
.name = "gpio",
 };
-- 
2.7.4