Re: [PATCH 2/2] qlcnic: add const to bin_attribute structure

[David Miller]

From: Bhumika Goyal 
Date: Wed,  2 Aug 2017 23:27:14 +0530

> Add const to bin_attribute structure as it is only passed to the
> functions sysfs_{remove/create}_bin_file. The corresponding
> arguments are of type const, so declare the structure to be const.
> 
> Signed-off-by: Bhumika Goyal 

Applied.

Re: [PATCH 2/2] qlcnic: add const to bin_attribute structure

[Patil, Harish]

-Original Message-
From: Bhumika Goyal <bhumi...@gmail.com>
Date: Wednesday, August 2, 2017 at 11:27 PM
To: "julia.law...@lip6.fr" <julia.law...@lip6.fr>, "kv...@codeaurora.org"
<kv...@codeaurora.org>, "linux-wirel...@vger.kernel.org"
<linux-wirel...@vger.kernel.org>, "netdev@vger.kernel.org"
<netdev@vger.kernel.org>, "linux-ker...@vger.kernel.org"
<linux-ker...@vger.kernel.org>, Harish Patil <harish.pa...@cavium.com>,
"Chopra, Manish" <manish.cho...@cavium.com>, Dept-GE Linux NIC Dev
<dept-gelinuxnic...@cavium.com>
Cc: Bhumika Goyal <bhumi...@gmail.com>
Subject: [PATCH 2/2] qlcnic: add const to bin_attribute structure

>Add const to bin_attribute structure as it is only passed to the
>functions sysfs_{remove/create}_bin_file. The corresponding
>arguments are of type const, so declare the structure to be const.
>
>Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
>---
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
>b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
>index 73027a6..82fcb83 100644
>--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
>+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
>@@ -1248,7 +1248,7 @@ static ssize_t
>qlcnic_83xx_sysfs_flash_write_handler(struct file *filp,
>   .write = qlcnic_sysfs_write_pm_config,
> };
> 
>-static struct bin_attribute bin_attr_flash = {
>+static const struct bin_attribute bin_attr_flash = {
>   .attr = {.name = "flash", .mode = (S_IRUGO | S_IWUSR)},
>   .size = 0,
>   .read = qlcnic_83xx_sysfs_flash_read_handler,
>-- 
>1.9.1
>
>Acked-by: Harish Patil <harish.pa...@cavium.com>

[PATCH 2/2] qlcnic: add const to bin_attribute structure

[Bhumika Goyal]

Add const to bin_attribute structure as it is only passed to the
functions sysfs_{remove/create}_bin_file. The corresponding
arguments are of type const, so declare the structure to be const.

Signed-off-by: Bhumika Goyal 
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c 
b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
index 73027a6..82fcb83 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
@@ -1248,7 +1248,7 @@ static ssize_t 
qlcnic_83xx_sysfs_flash_write_handler(struct file *filp,
.write = qlcnic_sysfs_write_pm_config,
 };
 
-static struct bin_attribute bin_attr_flash = {
+static const struct bin_attribute bin_attr_flash = {
.attr = {.name = "flash", .mode = (S_IRUGO | S_IWUSR)},
.size = 0,
.read = qlcnic_83xx_sysfs_flash_read_handler,
-- 
1.9.1