Re: [PATCH 2/2]d80211: add hardware scan callback

2006-09-21 Thread Jiri Benc
On Fri, 01 Sep 2006 15:34:38 +0800, Hong Liu wrote: Thanks for point this out! Change to only set sta_scanning to 1 if hw_scan successes. Applied to my tree. Thanks for the patch! Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH 2/2]d80211: add hardware scan callback

2006-09-01 Thread Hong Liu
On Fri, 2006-09-01 at 14:41, Johannes Berg wrote: On Fri, 2006-09-01 at 11:37 +0800, Hong Liu wrote: + local-sta_scanning = 1; + if (local-hw-hw_scan) + return local-hw-hw_scan(dev, ssid, ssid_len); + My question still stands, is it proper to assign sta_scanning

Re: [PATCH 2/2]d80211: add hardware scan callback

2006-08-31 Thread Hong Liu
On Thu, 2006-08-31 at 01:10, Jiri Benc wrote: On Fri, 25 Aug 2006 16:32:13 +0800, Hong Liu wrote: Add hardware scan callback to support cards like ipw3945 which implements the scan command in firmware. How ipw3945 performs scan? From the patch, it looks like it switches channels (and

Re: [PATCH 2/2]d80211: add hardware scan callback

2006-08-30 Thread Jiri Benc
On Fri, 25 Aug 2006 16:32:13 +0800, Hong Liu wrote: Add hardware scan callback to support cards like ipw3945 which implements the scan command in firmware. How ipw3945 performs scan? From the patch, it looks like it switches channels (and sends probe requests) in the firmware and delivers all

Re: [PATCH 2/2]d80211: add hardware scan callback

2006-08-30 Thread Mohamed Abbas
3945 firmware and hardware still do time critical functions like Beaconing and power management. This restrict us once associated to switch channel from the driver. we need to unassociated first before switching to a new channel. Because of this restriction while associated we can only call

Re: [PATCH 2/2]d80211: add hardware scan callback

2006-08-29 Thread Johannes Berg
On Fri, 2006-08-25 at 16:32 +0800, Hong Liu wrote: + local-sta_scanning = 1; + if (local-hw-hw_scan) + return local-hw-hw_scan(dev, ssid, ssid_len); You set sta_scanning even if that returns an error, is that correct? johannes - To unsubscribe from this list: send

[PATCH 2/2]d80211: add hardware scan callback

2006-08-25 Thread Hong Liu
Add hardware scan callback to support cards like ipw3945 which implements the scan command in firmware. Thanks, Hong diff --git a/include/net/d80211.h b/include/net/d80211.h index ba5cb4c..b369d12 100644 --- a/include/net/d80211.h +++ b/include/net/d80211.h @@ -595,6 +595,10 @@ struct