Re: [PATCH 2/3] net: socionext: Add Synquacer NetSec driver

2017-11-30 Thread David Miller
From: Ard Biesheuvel Date: Thu, 30 Nov 2017 18:08:34 + > But the whole point of memremap() is obtaining a virtual mapping > that does not require accessors, but can be used like ordinary > memory. That's unfortunately not what it's doing. It's relying on the fact that some architectures (I

Re: [PATCH 2/3] net: socionext: Add Synquacer NetSec driver

2017-11-30 Thread Ard Biesheuvel
On 30 November 2017 at 17:58, David Miller wrote: > From: Ard Biesheuvel > Date: Thu, 30 Nov 2017 17:48:44 + > >> On 30 November 2017 at 17:42, David Miller wrote: >>> From: Ard Biesheuvel >>> Date: Thu, 30 Nov 2017 17:37:27 + >>> Well, the whole point of using memremap() instead o

Re: [PATCH 2/3] net: socionext: Add Synquacer NetSec driver

2017-11-30 Thread David Miller
From: Ard Biesheuvel Date: Thu, 30 Nov 2017 17:48:44 + > On 30 November 2017 at 17:42, David Miller wrote: >> From: Ard Biesheuvel >> Date: Thu, 30 Nov 2017 17:37:27 + >> >>> Well, the whole point of using memremap() instead of ioremap() is that >>> the region has memory semantics, i.e.

Re: [PATCH 2/3] net: socionext: Add Synquacer NetSec driver

2017-11-30 Thread Ard Biesheuvel
On 30 November 2017 at 17:42, David Miller wrote: > From: Ard Biesheuvel > Date: Thu, 30 Nov 2017 17:37:27 + > >> Well, the whole point of using memremap() instead of ioremap() is that >> the region has memory semantics, i.e., we read the MAC address and the >> DMA engine microcode from it. I

Re: [PATCH 2/3] net: socionext: Add Synquacer NetSec driver

2017-11-30 Thread David Miller
From: Ard Biesheuvel Date: Thu, 30 Nov 2017 17:37:27 + > Well, the whole point of using memremap() instead of ioremap() is that > the region has memory semantics, i.e., we read the MAC address and the > DMA engine microcode from it. If memremap() itself is flawed in this > regard, I agree we

Re: [PATCH 2/3] net: socionext: Add Synquacer NetSec driver

2017-11-30 Thread Ard Biesheuvel
(+ Dan, Will) On 30 November 2017 at 17:29, David Miller wrote: > From: jassisinghb...@gmail.com > Date: Thu, 30 Nov 2017 21:43:16 +0530 > >> + priv->eeprom_base = devm_memremap(&pdev->dev, eeprom_res->start, >> + resource_size(eeprom_res), >> +

Re: [PATCH 2/3] net: socionext: Add Synquacer NetSec driver

2017-11-30 Thread David Miller
From: jassisinghb...@gmail.com Date: Thu, 30 Nov 2017 21:43:16 +0530 > + priv->eeprom_base = devm_memremap(&pdev->dev, eeprom_res->start, > + resource_size(eeprom_res), > + MEMREMAP_WT); > + if (!priv->eeprom_base)

[PATCH 2/3] net: socionext: Add Synquacer NetSec driver

2017-11-30 Thread jassisinghbrar
From: Jassi Brar This driver adds support for Socionext "netsec" IP Gigabit Ethernet + PHY IP used in the Synquacer SC2A11 SoC. Signed-off-by: Ard Biesheuvel Signed-off-by: Jassi Brar --- drivers/net/ethernet/Kconfig|1 + drivers/net/ethernet/Makefile |1 + drive