Re: [PATCH 2/4] forcedeth: fix power management support

2007-05-29 Thread Andi Kleen
Ayaz Abdulla [EMAIL PROTECTED] writes: This patch fixes the power management functions. It includes lowering the phy speed to conserve power. Shouldn't there be some way to disable this? AFAIK a few old switches have trouble with this. I assume a new ethtool option would be appropiate since we

Re: [PATCH 2/4] forcedeth: fix power management support

2007-05-24 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch fixes the power management functions. It includes lowering the phy speed to conserve power. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] Several issues here: 1) Your patch description needs to explain the problems in the power management code. It is

[PATCH 2/4] forcedeth: fix power management support

2007-05-21 Thread Ayaz Abdulla
This patch fixes the power management functions. It includes lowering the phy speed to conserve power. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2007-05-01 15:32:03.0 -0400 +++ new/drivers/net/forcedeth.c 2007-05-21 19:54:39.0 -0400 @@ -812,6