Re: [PATCH 2/6] rhashtable: remove incorrect comment on r{hl, hash}table_walk_enter()

On Mon, Apr 23, 2018 at 11:39:17AM +1000, NeilBrown wrote: > > Sound fair. Could you Ack the following? Then I'll resend all the > patches that have an ack. > I've realised that the "further improve stability of rhashtable_walk" > patch isn't actually complete, so I'll withdraw that for now.

Re: [PATCH 2/6] rhashtable: remove incorrect comment on r{hl, hash}table_walk_enter()

On Thu, Apr 19 2018, Herbert Xu wrote: > On Thu, Apr 19, 2018 at 08:56:28AM +1000, NeilBrown wrote: >> >> I don't want to do that - I just want the documentation to be correct >> (or at least, not be blatantly incorrect). The function does not sleep, >> and is safe to call with spin locks held.

Re: [PATCH 2/6] rhashtable: remove incorrect comment on r{hl, hash}table_walk_enter()

On Thu, Apr 19, 2018 at 08:56:28AM +1000, NeilBrown wrote: > > I don't want to do that - I just want the documentation to be correct > (or at least, not be blatantly incorrect). The function does not sleep, > and is safe to call with spin locks held. > Do we need to spell out when it can be

Re: [PATCH 2/6] rhashtable: remove incorrect comment on r{hl, hash}table_walk_enter()

On Wed, Apr 18 2018, Herbert Xu wrote: > On Wed, Apr 18, 2018 at 04:47:01PM +1000, NeilBrown wrote: >> Neither rhashtable_walk_enter() or rhltable_walk_enter() sleep, so >> remove the comments which suggest that they do. >> >> Signed-off-by: NeilBrown >> --- >>

Re: [PATCH 2/6] rhashtable: remove incorrect comment on r{hl, hash}table_walk_enter()

On Wed, Apr 18, 2018 at 04:47:01PM +1000, NeilBrown wrote: > Neither rhashtable_walk_enter() or rhltable_walk_enter() sleep, so > remove the comments which suggest that they do. > > Signed-off-by: NeilBrown > --- > include/linux/rhashtable.h |3 --- > lib/rhashtable.c

[PATCH 2/6] rhashtable: remove incorrect comment on r{hl, hash}table_walk_enter()

Neither rhashtable_walk_enter() or rhltable_walk_enter() sleep, so remove the comments which suggest that they do. Signed-off-by: NeilBrown --- include/linux/rhashtable.h |3 --- lib/rhashtable.c |3 --- 2 files changed, 6 deletions(-) diff --git

[PATCH 2/6] rhashtable: remove incorrect comment on r{hl, hash}table_walk_enter()

Neither rhashtable_walk_enter() or rhltable_walk_enter() sleep, so remove the comments which suggest that they do. Signed-off-by: NeilBrown --- include/linux/rhashtable.h |3 --- lib/rhashtable.c |3 --- 2 files changed, 6 deletions(-) diff --git