Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

2016-03-19 Thread Parav Pandit
On Sat, Mar 19, 2016 at 4:58 PM, oulijun wrote: > On 2016/3/15 2:20, Parav Pandit wrote: Since SRQ is not supported in this driver version, can you keep remaining code base also to not bother about SRQ specifically poll_cq_one, modify_qp, destroy_qp etc?

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

2016-03-19 Thread oulijun
On 2016/3/15 2:20, Parav Pandit wrote: >>> >>> Since SRQ is not supported in this driver version, can you keep >>> remaining code base also to not bother about SRQ specifically >>> poll_cq_one, modify_qp, destroy_qp etc? >>> SRQ support can come as complete additional patch along with cmd_mask,

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

2016-03-14 Thread Parav Pandit
>> >> Since SRQ is not supported in this driver version, can you keep >> remaining code base also to not bother about SRQ specifically >> poll_cq_one, modify_qp, destroy_qp etc? >> SRQ support can come as complete additional patch along with cmd_mask, >> callbacks and rest of the code. >> >> . >

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

2016-03-14 Thread oulijun
Hi Parav Pandit, thanks your reviewing. On 2016/3/4 17:37, Parav Pandit wrote: > On Fri, Mar 4, 2016 at 2:11 PM, Wei Hu(Xavier) > wrote: >> + >> +int hns_roce_register_device(struct hns_roce_dev *hr_dev) >> +{ >> + int ret; >> + struct hns_roce_ib_iboe *iboe

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

2016-03-09 Thread Jiri Pirko
Wed, Mar 09, 2016 at 12:18:06PM CET, ouli...@huawei.com wrote: >Hi Jiri Pirko, thanks for reviewing >On 2016/3/4 17:16, Jiri Pirko wrote: >> Fri, Mar 04, 2016 at 09:41:16AM CET, xavier.hu...@huawei.com wrote: >> >> >> >>> +int hns_roce_buf_alloc( >>> + struct hns_roce_dev

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

2016-03-09 Thread oulijun
Hi Jiri Pirko, thanks for reviewing On 2016/3/4 17:16, Jiri Pirko wrote: > Fri, Mar 04, 2016 at 09:41:16AM CET, xavier.hu...@huawei.com wrote: > > > >> +int hns_roce_buf_alloc( >> +struct hns_roce_dev *hr_dev, >> +int size, int max_direct, >> +

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

2016-03-04 Thread Parav Pandit
On Fri, Mar 4, 2016 at 2:11 PM, Wei Hu(Xavier) wrote: > + > +int hns_roce_register_device(struct hns_roce_dev *hr_dev) > +{ > + int ret; > + struct hns_roce_ib_iboe *iboe = NULL; > + struct ib_device *ib_dev = NULL; > + struct device *dev =

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

2016-03-04 Thread Jiri Pirko
Fri, Mar 04, 2016 at 09:41:16AM CET, xavier.hu...@huawei.com wrote: >+int hns_roce_buf_alloc( >+ struct hns_roce_dev *hr_dev, >+ int size, int max_direct, >+ struct hns_roce_buf *buf) >+ >+ pages =