Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

2016-09-27 Thread Kalle Valo
Rafał Miłecki writes: > Kalle: this isn't important enough for 4.8 as it's too late for that. > > I'd like to get it for 4.9 however, as this fixes bug that could lead > to WARNING on every add_key/del_key call. We was struggling with these > WARNINGs for some time and this fi

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

2016-09-27 Thread Rafał Miłecki
On 27 September 2016 at 14:04, Arend Van Spriel wrote: > On 27-9-2016 13:58, Rafał Miłecki wrote: >> On 27 September 2016 at 13:44, Rafał Miłecki wrote: >>> On 27 September 2016 at 13:27, Kalle Valo wrote: Arend Van Spriel writes: > On 27-9-2016 11:14, Rafał Miłecki wrote: >>

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

2016-09-27 Thread Arend Van Spriel
On 27-9-2016 13:58, Rafał Miłecki wrote: > On 27 September 2016 at 13:44, Rafał Miłecki wrote: >> On 27 September 2016 at 13:27, Kalle Valo wrote: >>> Arend Van Spriel writes: >>> On 27-9-2016 11:14, Rafał Miłecki wrote: > From: Rafał Miłecki > > Flowrings contain skbs waiting

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

2016-09-27 Thread Rafał Miłecki
On 27 September 2016 at 13:44, Rafał Miłecki wrote: > On 27 September 2016 at 13:27, Kalle Valo wrote: >> Arend Van Spriel writes: >> >>> On 27-9-2016 11:14, Rafał Miłecki wrote: From: Rafał Miłecki Flowrings contain skbs waiting for transmission that were passed to us by ne

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

2016-09-27 Thread Rafał Miłecki
On 27 September 2016 at 13:27, Kalle Valo wrote: > Arend Van Spriel writes: > >> On 27-9-2016 11:14, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> Flowrings contain skbs waiting for transmission that were passed to us >>> by netif. It means we checked every one of them looking for 802.1x

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

2016-09-27 Thread Arend Van Spriel
On 27-9-2016 13:27, Kalle Valo wrote: > Arend Van Spriel writes: > >> On 27-9-2016 11:14, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> Flowrings contain skbs waiting for transmission that were passed to us >>> by netif. It means we checked every one of them looking for 802.1x >>> Etherne

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

2016-09-27 Thread Kalle Valo
Arend Van Spriel writes: > On 27-9-2016 11:14, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> Flowrings contain skbs waiting for transmission that were passed to us >> by netif. It means we checked every one of them looking for 802.1x >> Ethernet type. When deleting flowring we have to use f

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

2016-09-27 Thread Arend Van Spriel
On 27-9-2016 11:14, Rafał Miłecki wrote: > From: Rafał Miłecki > > Flowrings contain skbs waiting for transmission that were passed to us > by netif. It means we checked every one of them looking for 802.1x > Ethernet type. When deleting flowring we have to use freeing function > that will check

[PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

2016-09-27 Thread Rafał Miłecki
From: Rafał Miłecki Flowrings contain skbs waiting for transmission that were passed to us by netif. It means we checked every one of them looking for 802.1x Ethernet type. When deleting flowring we have to use freeing function that will check for 802.1x type as well. Freeing skbs without a prop