Re: [PATCH RFC 04/13] net: phy: add 1000Base-X to phy settings table

[Andrew Lunn]

On Tue, Jul 25, 2017 at 03:02:52PM +0100, Russell King wrote:
> Add the missing 1000Base-X entry to the phy settings table.  This was
> not included because the original code could not cope with more than
> 32 bits of link mode mask.
> 
> Signed-off-by: Russell King 

Hi Russell

Looks like there are another 15 to add to the table. But that can wait
for another time when somebody needs them.

Reviewed-by: Andrew Lunn 

Andrew

[PATCH RFC 04/13] net: phy: add 1000Base-X to phy settings table

[Russell King]

Add the missing 1000Base-X entry to the phy settings table.  This was
not included because the original code could not cope with more than
32 bits of link mode mask.

Signed-off-by: Russell King 
---
 drivers/net/phy/phy-core.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/phy/phy-core.c b/drivers/net/phy/phy-core.c
index c07845e77004..21f75ae244b3 100644
--- a/drivers/net/phy/phy-core.c
+++ b/drivers/net/phy/phy-core.c
@@ -90,6 +90,11 @@ static const struct phy_setting settings[] = {
{
.speed = SPEED_1000,
.duplex = DUPLEX_FULL,
+   .bit = ETHTOOL_LINK_MODE_1000baseX_Full_BIT,
+   },
+   {
+   .speed = SPEED_1000,
+   .duplex = DUPLEX_FULL,
.bit = ETHTOOL_LINK_MODE_1000baseT_Full_BIT,
},
{
-- 
2.7.4