Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-14 Thread Tariq Toukan
On 08/09/2016 12:31 PM, Or Gerlitz wrote: On Thu, Sep 8, 2016 at 10:38 AM, Jesper Dangaard Brouer wrote: On Wed, 7 Sep 2016 23:55:42 +0300 Or Gerlitz wrote: On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: From: Rana

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-08 Thread Jamal Hadi Salim
On 16-09-07 08:42 AM, Saeed Mahameed wrote: Comparison is done between: 1. Baseline, Before this patch with TC drop action 2. This patch with TC drop action 3. This patch with XDP RX fast drop StreamsBaseline(TC drop)TC dropXDP fast Drop

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-08 Thread Jesper Dangaard Brouer
On Thu, 8 Sep 2016 12:31:47 +0300 Or Gerlitz wrote: > On Thu, Sep 8, 2016 at 10:38 AM, Jesper Dangaard Brouer > wrote: > > On Wed, 7 Sep 2016 23:55:42 +0300 > > Or Gerlitz wrote: > > > >> On Wed, Sep 7, 2016 at 3:42 PM, Saeed

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-08 Thread Or Gerlitz
On Thu, Sep 8, 2016 at 10:38 AM, Jesper Dangaard Brouer wrote: > On Wed, 7 Sep 2016 23:55:42 +0300 > Or Gerlitz wrote: > >> On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: >> > From: Rana Shahout >> > >> >

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-08 Thread Jesper Dangaard Brouer
On Wed, 7 Sep 2016 23:55:42 +0300 Or Gerlitz wrote: > On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: > > From: Rana Shahout > > > > Add support for the BPF_PROG_TYPE_PHYS_DEV hook in mlx5e driver. > > > > When XDP is on we

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-08 Thread Jesper Dangaard Brouer
On Wed, 7 Sep 2016 20:07:01 +0300 Saeed Mahameed wrote: > On Wed, Sep 7, 2016 at 7:54 PM, Tom Herbert wrote: > > On Wed, Sep 7, 2016 at 7:48 AM, Saeed Mahameed > > wrote: > >> On Wed, Sep 7, 2016 at 4:32 PM, Or

Re: [iovisor-dev] [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-08 Thread Or Gerlitz
On Thu, Sep 8, 2016 at 12:53 AM, Saeed Mahameed wrote: > On Wed, Sep 7, 2016 at 11:55 PM, Or Gerlitz via iovisor-dev > wrote: >> On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: >>> From: Rana Shahout

Re: [iovisor-dev] [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-07 Thread Saeed Mahameed
On Wed, Sep 7, 2016 at 11:55 PM, Or Gerlitz via iovisor-dev wrote: > On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: >> From: Rana Shahout >> >> Add support for the BPF_PROG_TYPE_PHYS_DEV hook in mlx5e driver. >> >>

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-07 Thread Or Gerlitz
On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: > From: Rana Shahout > > Add support for the BPF_PROG_TYPE_PHYS_DEV hook in mlx5e driver. > > When XDP is on we make sure to change channels RQs type to > MLX5_WQ_TYPE_LINKED_LIST rather than "striding

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-07 Thread Saeed Mahameed
On Wed, Sep 7, 2016 at 7:54 PM, Tom Herbert wrote: > On Wed, Sep 7, 2016 at 7:48 AM, Saeed Mahameed > wrote: >> On Wed, Sep 7, 2016 at 4:32 PM, Or Gerlitz wrote: >>> On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-07 Thread Tom Herbert
On Wed, Sep 7, 2016 at 7:48 AM, Saeed Mahameed wrote: > On Wed, Sep 7, 2016 at 4:32 PM, Or Gerlitz wrote: >> On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: >> >>> Packet rate performance testing was done with pktgen

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-07 Thread Saeed Mahameed
On Wed, Sep 7, 2016 at 4:32 PM, Or Gerlitz wrote: > On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: > >> Packet rate performance testing was done with pktgen 64B packets and on >> TX side and, TC drop action on RX side compared to XDP fast drop.

Re: [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-07 Thread Or Gerlitz
On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: > Packet rate performance testing was done with pktgen 64B packets and on > TX side and, TC drop action on RX side compared to XDP fast drop. > > CPU: Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz > > Comparison is done

[PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-07 Thread Saeed Mahameed
From: Rana Shahout Add support for the BPF_PROG_TYPE_PHYS_DEV hook in mlx5e driver. When XDP is on we make sure to change channels RQs type to MLX5_WQ_TYPE_LINKED_LIST rather than "striding RQ" type to ensure "page per packet". On XDP set, we fail if HW LRO is set and