Re: [PATCH RFC net-next 2/7] net: add dst_pending_confirm flag to skbuff

2017-01-21 Thread Julian Anastasov
Hello, On Fri, 20 Jan 2017, YueHaibing wrote: > Sorry for so late reply. > I have test your new patch, It works well in my scene. Thanks! I'll prepare 2nd version in the following days... Regards -- Julian Anastasov

Re: [PATCH RFC net-next 2/7] net: add dst_pending_confirm flag to skbuff

2017-01-19 Thread YueHaibing
On 2016/12/20 4:37, Julian Anastasov wrote: > > Hello, > > On Mon, 19 Dec 2016, Eric Dumazet wrote: > >> I am still digesting this awesome patch series ;) > > Thanks. I don't feel quite comfortable with some > of the changes (mostly XFRM, dst_confirm usage in CXGB) and > I hope

Re: [PATCH RFC net-next 2/7] net: add dst_pending_confirm flag to skbuff

2016-12-19 Thread Julian Anastasov
Hello, On Mon, 19 Dec 2016, Eric Dumazet wrote: > I am still digesting this awesome patch series ;) Thanks. I don't feel quite comfortable with some of the changes (mostly XFRM, dst_confirm usage in CXGB) and I hope the discussion can provide adequate solution. > Not sure why

Re: [PATCH RFC net-next 2/7] net: add dst_pending_confirm flag to skbuff

2016-12-19 Thread Hannes Frederic Sowa
On 19.12.2016 17:40, Eric Dumazet wrote: > On Mon, 2016-12-19 at 17:36 +0100, Hannes Frederic Sowa wrote: >> On 19.12.2016 17:17, Eric Dumazet wrote: >>> On Sun, 2016-12-18 at 22:56 +0200, Julian Anastasov wrote: >>> +static inline void sock_confirm_neigh(struct sk_buff *skb, struct

Re: [PATCH RFC net-next 2/7] net: add dst_pending_confirm flag to skbuff

2016-12-19 Thread Eric Dumazet
On Mon, 2016-12-19 at 17:36 +0100, Hannes Frederic Sowa wrote: > On 19.12.2016 17:17, Eric Dumazet wrote: > > On Sun, 2016-12-18 at 22:56 +0200, Julian Anastasov wrote: > > > >> > >> +static inline void sock_confirm_neigh(struct sk_buff *skb, struct > >> neighbour *n) > >> +{ > >> + if

Re: [PATCH RFC net-next 2/7] net: add dst_pending_confirm flag to skbuff

2016-12-19 Thread Hannes Frederic Sowa
On 19.12.2016 17:17, Eric Dumazet wrote: > On Sun, 2016-12-18 at 22:56 +0200, Julian Anastasov wrote: > >> >> +static inline void sock_confirm_neigh(struct sk_buff *skb, struct neighbour >> *n) >> +{ >> +if (unlikely(skb->dst_pending_confirm)) { >> +struct sock *sk = skb->sk;

Re: [PATCH RFC net-next 2/7] net: add dst_pending_confirm flag to skbuff

2016-12-19 Thread Eric Dumazet
On Sun, 2016-12-18 at 22:56 +0200, Julian Anastasov wrote: > > +static inline void sock_confirm_neigh(struct sk_buff *skb, struct neighbour > *n) > +{ > + if (unlikely(skb->dst_pending_confirm)) { > + struct sock *sk = skb->sk; > + unsigned long now = jiffies; > + >

[PATCH RFC net-next 2/7] net: add dst_pending_confirm flag to skbuff

2016-12-18 Thread Julian Anastasov
Add new skbuff flag to allow protocols to confirm neighbour. When same struct dst_entry can be used for many different neighbours we can not use it for pending confirmations. Add sock_confirm_neigh() helper to confirm the neighbour and use it for IPv4, IPv6 and VRF before dst_neigh_output.