Re: [PATCH RFT v2] sh_eth: fix kernel oops in skb_put()

2015-11-20 Thread Yasushi SHOJI
Hi Sergei, On Fri, 20 Nov 2015 02:53:39 +0900, Sergei Shtylyov wrote: > >Shoji-san, can I push this patch to net.git? I doubt that it has > ill effects in itself -- the reason of the slowdown you're seeing > should be somewhere else... Sure. I've tested and the null access problem is gone

Re: [PATCH RFT v2] sh_eth: fix kernel oops in skb_put()

2015-11-19 Thread Sergei Shtylyov
Hello. On 10/27/2015 01:52 AM, Yasushi SHOJI wrote: In a low memory situation the following kernel oops occurs: Unable to handle kernel NULL pointer dereference at virtual address 0050 pgd = 8490c000 [0050] *pgd=4651e831, *pte=, *ppte= Internal error: Oops: 17 [#1]

Re: [PATCH RFT v2] sh_eth: fix kernel oops in skb_put()

2015-10-30 Thread David Miller
From: Sergei Shtylyov Date: Sun, 25 Oct 2015 01:42:33 +0300 > In a low memory situation the following kernel oops occurs: ... > This is because netdev_alloc_skb() fails and 'mdp->rx_skbuff[entry]' is left > NULL but sh_eth_rx() later uses it without checking.

Re: [PATCH RFT v2] sh_eth: fix kernel oops in skb_put()

2015-10-26 Thread Yasushi SHOJI
Hi Sergei, Thank you for your patch! On Sun, 25 Oct 2015 07:42:33 +0900, Sergei Shtylyov wrote: > > In a low memory situation the following kernel oops occurs: > > Unable to handle kernel NULL pointer dereference at virtual address 0050 > pgd = 8490c000 > [0050] *pgd=4651e831,

[PATCH RFT v2] sh_eth: fix kernel oops in skb_put()

2015-10-24 Thread Sergei Shtylyov
In a low memory situation the following kernel oops occurs: Unable to handle kernel NULL pointer dereference at virtual address 0050 pgd = 8490c000 [0050] *pgd=4651e831, *pte=, *ppte= Internal error: Oops: 17 [#1] PREEMPT ARM Modules linked in: CPU: 0Not tainted