Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW)

2016-02-26 Thread Florian Fainelli
On 26/02/16 07:24, John Crispin wrote: > > Hi, > > would the series be ok if we just dropped those parts and then have a > driver in the kernel that wont do much with the out of tree patches ? > > the problem here is that on one side people complain about vendors not > sending code upstream.

Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW)

2016-02-26 Thread David Miller
From: Andrew Lunn Date: Fri, 26 Feb 2016 18:05:45 +0100 > I think it is great a vendor is providing funding to get code > upstream. However, that code needs to conform with current kernel > architecture and design philosophy. > > We as a community also need to be consistent. We

Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW)

2016-02-26 Thread David Miller
From: Felix Fietkau Date: Fri, 26 Feb 2016 17:25:38 +0100 > In my opinion, leaving this part out does not make much sense and > neither does deferring the entire patch series until we have a > switchdev/DSA capable driver. This is just a starting point, which will > be turned

Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW)

2016-02-26 Thread David Miller
From: John Crispin Date: Fri, 26 Feb 2016 16:24:47 +0100 > the problem here is that on one side people complain about vendors not > sending code upstream. once they start being a good citizen and provide > funding to send stuff upstream the feedback tends to be very bad as

Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW)

2016-02-26 Thread David Miller
From: Andrew Lunn Date: Fri, 26 Feb 2016 16:18:13 +0100 > On Fri, Feb 26, 2016 at 03:21:35PM +0100, John Crispin wrote: >> The ESW is found in many of the old 100mbit MIPS based SoCs. it has 5 >> external ports, 1 cpu port and 1 further port that the internal HW >> offloading

Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW)

2016-02-26 Thread Andrew Lunn
On Fri, Feb 26, 2016 at 05:25:38PM +0100, Felix Fietkau wrote: > On 2016-02-26 16:18, Andrew Lunn wrote: > > On Fri, Feb 26, 2016 at 03:21:35PM +0100, John Crispin wrote: > >> The ESW is found in many of the old 100mbit MIPS based SoCs. it has 5 > >> external ports, 1 cpu port and 1 further port

Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW)

2016-02-26 Thread Andrew Lunn
> the problem here is that on one side people complain about vendors not > sending code upstream. once they start being a good citizen and provide > funding to send stuff upstream the feedback tends to be very bad as seen > here. we are planning on doing a DSA driver but one step at a time. this >

Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW)

2016-02-26 Thread Felix Fietkau
On 2016-02-26 16:18, Andrew Lunn wrote: > On Fri, Feb 26, 2016 at 03:21:35PM +0100, John Crispin wrote: >> The ESW is found in many of the old 100mbit MIPS based SoCs. it has 5 >> external ports, 1 cpu port and 1 further port that the internal HW >> offloading engine connects to. >> >> This

Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW)

2016-02-26 Thread John Crispin
On 26/02/2016 16:18, Andrew Lunn wrote: > On Fri, Feb 26, 2016 at 03:21:35PM +0100, John Crispin wrote: >> The ESW is found in many of the old 100mbit MIPS based SoCs. it has 5 >> external ports, 1 cpu port and 1 further port that the internal HW >> offloading engine connects to. >> >> This

Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW)

2016-02-26 Thread Andrew Lunn
On Fri, Feb 26, 2016 at 03:21:35PM +0100, John Crispin wrote: > The ESW is found in many of the old 100mbit MIPS based SoCs. it has 5 > external ports, 1 cpu port and 1 further port that the internal HW > offloading engine connects to. > > This driver is very basic and only provides basic init

[PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW)

2016-02-26 Thread John Crispin
The ESW is found in many of the old 100mbit MIPS based SoCs. it has 5 external ports, 1 cpu port and 1 further port that the internal HW offloading engine connects to. This driver is very basic and only provides basic init and irq support. The SoC and switch core both have support for a special